Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add HTTP option to control the size of streaming responses #10183

Merged
merged 7 commits into from
Sep 28, 2021
Merged

Add HTTP option to control the size of streaming responses #10183

merged 7 commits into from
Sep 28, 2021

Conversation

ofek
Copy link
Contributor

@ofek ofek commented Sep 21, 2021 •
edited
Loading

Motivation

Customer request, connections may be interrupted during the processing of large payloads

@ofek ofek requested review from a team as code owners September 21, 2021 14:09
yzhan289
yzhan289 approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@yzhan289 yzhan289 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, just a small question

...cks_dev/datadog_checks/dev/tooling/templates/configuration/instances/openmetrics_legacy.yaml
@@ -179,4 +179,6 @@
- <TAG_PREFIX:.*>
- <TAG_SUFFIX$>
- template: instances/http
overrides:
request_size.value.example: 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this overridden to 10 instead of 16?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep current behavior #10183 (review)

sarah-witt
sarah-witt approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@sarah-witt sarah-witt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@ofek ofek merged commit b1d2b0f into master Sep 28, 2021
@ofek ofek deleted the ofek/h branch September 28, 2021 13:41
github-actions bot pushed a commit that referenced this pull request Sep 28, 2021
@ofek
Add HTTP option to control the size of streaming responses (#10183)
2e53dc4 
* Add HTTP option to control the size of streaming responses

* wrap `requests.Response` objects

* sync config

* fix

* update example config b1d2b0f
@ofek ofek mentioned this pull request Sep 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah-witt sarah-witt sarah-witt approved these changes

@yzhan289 yzhan289 yzhan289 approved these changes

@ChristineTChen ChristineTChen ChristineTChen approved these changes

@alai97 alai97 alai97 left review comments

Assignees
No one assigned
Labels
dependencies dev/tooling integration/activemq_xml integration/airflow integration/amazon_msk integration/ambari integration/apache integration/avi_vantage integration/azure_iot_edge integration/cilium integration/cisco_aci integration/citrix_hypervisor integration/cloud_foundry_api integration/cockroachdb integration/consul integration/coredns integration/couch integration/couchbase integration/crio integration/datadog_checks_base integration/datadog_checks_dev integration/datadog_cluster_agent integration/druid integration/ecs_fargate integration/eks_fargate integration/elastic integration/envoy integration/etcd integration/external_dns integration/fluentd integration/gitlab_runner integration/gitlab integration/go_expvar integration/haproxy integration/harbor integration/hazelcast integration/hdfs_datanode integration/hdfs_namenode integration/http_check integration/ibm_was integration/istio integration/kong integration/kube_apiserver_metrics integration/kube_scheduler integration/kyototycoon integration/lighttpd integration/linkerd integration/mapreduce integration/marathon integration/marklogic integration/mesos_master integration/mesos_slave integration/nginx_ingress_controller integration/nginx integration/openmetrics integration/openstack_controller integration/php_fpm integration/powerdns_recursor integration/rabbitmq integration/riak integration/scylla integration/sonarqube integration/spark integration/squid integration/teamcity integration/twistlock integration/vault integration/voltdb integration/vsphere integration/yarn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ofek @ChristineTChen @yzhan289 @sarah-witt @alai97