Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_redirect option #10160

Merged
merged 32 commits into from
Sep 21, 2021
Merged

Add allow_redirect option #10160

merged 32 commits into from
Sep 21, 2021

Conversation

HantingZhang2
Copy link
Contributor

What does this PR do?

Adds allow_redirect into the http wrapper

Motivation

psf/requests#4951

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #10160 (44efcea) into master (8128160) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Flag Coverage Δ
active_directory 100.00% <ø> (ø)
activemq_xml 82.31% <ø> (ø)
aerospike 86.97% <ø> (+0.36%) ⬆️
airflow 90.00% <ø> (ø)
amazon_msk 87.94% <ø> (ø)
ambari 85.75% <ø> (ø)
apache 95.43% <ø> (ø)
aspdotnet 93.87% <ø> (ø)
avi_vantage 92.12% <ø> (ø)
azure_iot_edge 82.01% <ø> (ø)
btrfs 82.91% <ø> (ø)
cacti 83.95% <ø> (ø)
cassandra_nodetool 94.19% <ø> (ø)
ceph 91.02% <ø> (ø)
cilium 85.84% <ø> (+1.88%) ⬆️
cisco_aci 95.88% <ø> (ø)
clickhouse 96.65% <ø> (ø)
cloud_foundry_api 95.98% <ø> (+0.12%) ⬆️
cockroachdb 97.18% <ø> (ø)
consul 91.74% <ø> (ø)
coredns 96.36% <ø> (ø)
couch 95.19% <ø> (+0.24%) ⬆️
couchbase 81.45% <ø> (ø)
crio 100.00% <ø> (ø)
datadog_checks_base 89.68% <100.00%> (+0.41%) ⬆️
datadog_checks_dev 80.38% <ø> (ø)
datadog_cluster_agent 97.50% <ø> (ø)
directory 94.87% <ø> (ø)
disk 91.15% <ø> (-0.49%) ⬇️
dns_check 94.00% <ø> (ø)
dotnetclr 100.00% <ø> (ø)
druid 97.70% <ø> (ø)
ecs_fargate 77.65% <ø> (ø)
eks_fargate 94.05% <ø> (ø)
elastic 88.65% <ø> (ø)
envoy 93.77% <ø> (+0.25%) ⬆️
etcd 93.09% <ø> (ø)
exchange_server 100.00% <ø> (ø)
external_dns 100.00% <ø> (ø)
fluentd 94.77% <ø> (ø)
gearmand 77.27% <ø> (+1.29%) ⬆️
gitlab 89.94% <ø> (ø)
gitlab_runner 91.94% <ø> (ø)
glusterfs 80.09% <ø> (+0.92%) ⬆️
go_expvar 92.49% <ø> (ø)
gunicorn 93.60% <ø> (ø)
haproxy 95.22% <ø> (+0.17%) ⬆️
harbor 81.84% <ø> (ø)
hazelcast 92.39% <ø> (ø)
hdfs_datanode 90.00% <ø> (ø)
hdfs_namenode 87.94% <ø> (ø)
http_check 90.37% <100.00%> (+2.19%) ⬆️
ibm_i 80.05% <ø> (ø)
ibm_mq 89.78% <ø> (+0.17%) ⬆️
ibm_was 97.44% <ø> (ø)
iis 93.01% <ø> (ø)
istio 77.67% <ø> (+0.59%) ⬆️
kafka_consumer 81.87% <ø> (ø)
kong 92.21% <ø> (ø)
kube_apiserver_metrics 97.35% <ø> (ø)
kube_controller_manager 96.85% <ø> (ø)
kube_dns 98.85% <ø> (ø)
kube_metrics_server 100.00% <ø> (ø)
kube_proxy 100.00% <ø> (ø)
kube_scheduler 96.20% <ø> (ø)
kubelet 89.47% <ø> (ø)
kubernetes_state 89.67% <ø> (ø)
kyototycoon 85.96% <ø> (ø)
lighttpd 83.64% <ø> (ø)
linkerd 85.14% <ø> (+1.14%) ⬆️
linux_proc_extras 96.22% <ø> (ø)
mapr 82.62% <ø> (ø)
mapreduce 82.27% <ø> (+0.45%) ⬆️
marathon 83.12% <ø> (ø)
marklogic 95.33% <ø> (ø)
mcache 93.48% <ø> (ø)
mesos_master 90.68% <ø> (ø)
mesos_slave 93.63% <ø> (ø)
mongo 94.43% <ø> (+0.28%) ⬆️
mysql 86.32% <ø> (+0.13%) ⬆️
nagios 89.53% <ø> (ø)
network 77.76% <ø> (+1.00%) ⬆️
nfsstat 95.20% <ø> (ø)
nginx 95.11% <ø> (+0.93%) ⬆️
nginx_ingress_controller 98.30% <ø> (ø)
openldap 96.33% <ø> (ø)
openmetrics 97.14% <ø> (ø)
openstack 51.30% <ø> (ø)
openstack_controller 90.74% <ø> (ø)
oracle 93.65% <ø> (+0.52%) ⬆️
pdh_check 97.77% <ø> (ø)
pgbouncer 90.45% <ø> (ø)
php_fpm 90.04% <ø> (+0.43%) ⬆️
postfix 88.04% <ø> (ø)
postgres 91.70% <ø> (+0.14%) ⬆️
powerdns_recursor 95.93% <ø> (ø)
process 85.07% <ø> (+0.28%) ⬆️
prometheus 94.17% <ø> (ø)
proxysql 98.97% <ø> (ø)
rabbitmq 93.74% <ø> (ø)
redisdb 86.96% <ø> (-0.32%) ⬇️
rethinkdb 97.93% <ø> (ø)
riak 99.22% <ø> (ø)
riakcs 93.61% <ø> (ø)
sap_hana 93.04% <ø> (ø)
scylla 100.00% <ø> (ø)
snmp 90.73% <ø> (+0.04%) ⬆️
sonarqube 95.69% <ø> (ø)
spark 93.64% <ø> (ø)
sqlserver 82.38% <ø> (ø)
squid 100.00% <ø> (ø)
ssh_check 91.58% <ø> (ø)
statsd 87.36% <ø> (+4.21%) ⬆️
supervisord 92.30% <ø> (ø)
system_core 91.04% <ø> (ø)
system_swap 98.30% <ø> (ø)
tcp_check 88.83% <ø> (ø)
teamcity 80.00% <100.00%> (ø)
tls 97.04% <ø> (+0.87%) ⬆️
tokumx 58.40% <ø> (?)
twemproxy 78.33% <ø> (ø)
twistlock 80.80% <ø> (ø)
varnish 84.57% <ø> (+0.24%) ⬆️
vault 94.91% <ø> (+0.53%) ⬆️
vertica 92.33% <ø> (ø)
voltdb 96.81% <ø> (ø)
vsphere 89.75% <ø> (+0.05%) ⬆️
win32_event_log 86.03% <ø> (+0.28%) ⬆️
windows_service 95.83% <ø> (ø)
wmi_check 92.91% <ø> (ø)
yarn 90.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@github-actions
Copy link

The validations job has failed; please review the Files changed tab for possible suggestions to resolve.

@coignetp coignetp changed the title Hanting add allow redirect Add allow_redirect option Sep 21, 2021
@coignetp coignetp merged commit 49fbb43 into master Sep 21, 2021
@coignetp coignetp deleted the hanting-add-allow-redirect branch September 21, 2021 13:14
github-actions bot pushed a commit that referenced this pull request Sep 21, 2021
* Set  allow_redirects to true by default

* Adds allow_redirects to all tests

* update .gitignore

New folder generated by docker if using docker compose v2

* Fixing tests

* Fix Style

* format fix

* Fix config model and config tests

* fix styles

* Set  allow_redirects to true by default

* Adds allow_redirects to all tests

* update .gitignore

New folder generated by docker if using docker compose v2

* Fixing tests

* Fix Style

* format fix

* Fix config model and config tests

* fix styles

* validate config and models

* Update typo

Co-authored-by: Paul <[email protected]>

* Update checks dependency provider

Co-authored-by: Paul <[email protected]>

* add allow_redirects to http template

* Update .gitignore

Co-authored-by: Paul <[email protected]>

* Validate config

* Validate new models

* validate models

* adds the option in ddev test

Co-authored-by: Paul <[email protected]> 49fbb43
@sarah-witt sarah-witt mentioned this pull request Sep 21, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/tooling documentation integration/activemq_xml integration/airflow integration/amazon_msk integration/ambari integration/apache integration/avi_vantage integration/azure_iot_edge integration/cilium integration/cisco_aci integration/cloud_foundry_api integration/cockroachdb integration/consul integration/coredns integration/couch integration/couchbase integration/crio integration/datadog_checks_base integration/datadog_checks_dependency_provider integration/datadog_checks_dev integration/datadog_cluster_agent integration/druid integration/ecs_fargate integration/eks_fargate integration/elastic integration/envoy integration/etcd integration/external_dns integration/fluentd integration/gitlab_runner integration/gitlab integration/go_expvar integration/haproxy integration/harbor integration/hazelcast integration/hdfs_datanode integration/hdfs_namenode integration/http_check integration/ibm_was integration/istio integration/kong integration/kube_apiserver_metrics integration/kube_scheduler integration/kubelet integration/kyototycoon integration/lighttpd integration/linkerd integration/mapreduce integration/marathon integration/marklogic integration/mesos_master integration/mesos_slave integration/nginx_ingress_controller integration/nginx integration/openmetrics integration/openstack_controller integration/php_fpm integration/powerdns_recursor integration/rabbitmq integration/riak integration/scylla integration/sonarqube integration/spark integration/squid integration/teamcity integration/twistlock integration/vault integration/voltdb integration/vsphere integration/yarn
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants