Fix Mypy tests #10134
Merged
Fix Mypy tests #10134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
integration/aerospike
integration/azure_iot_edge
integration/cloud_foundry_api
integration/datadog_checks_base
integration/datadog_checks_dev
integration/glusterfs
integration/ibm_mq
integration/marklogic
integration/mysql
integration/postgres
integration/rethinkdb
integration/snmp
integration/snowflake
integration/voltdb
integration/vsphere
labels
FlorianVeaux
force-pushed
the
flo/fix_master_mypy_tests
branch
from
00a1c03
to
ea28ba0
Compare
|
Can be tested locally with |
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
hithwen
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With mypy's bump, stubs for third-party libraries are not included anymore. They can be installed automatically by using
--install-typesand--non-interactiveflags but unfortunately some stubs are now py3 only while we use mypy in--py2mode.To workaround the issue, this PR gives check the ability to pass additional style dependencies in each check tox.ini file.