Echo warning for unnecessary params used #10053

ChristineTChen · 2021-09-03T20:04:58Z

This PR warns on usage of auth or header in http wrapper. These are already handled and is redundant

Instead of iterating each line of a python file, perhaps we can just regex search?

Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
PR title must be written as a CHANGELOG entry (see why)
Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
PR must have changelog/ and integration/ labels attached

codecov · 2021-09-03T20:34:47Z

Codecov Report

Merging #10053 (238517a) into master (9f83705) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Flags with carried forward coverage won't be shown. Click here to find out more.

ChristineTChen added 3 commits September 3, 2021 16:01

echo warning for unnecessary params used

d28a8ee

Format for readability

8c6d082

Improve readability

a03a3dc

ChristineTChen added the changelog/Added label Sep 3, 2021

ChristineTChen requested a review from a team as a code owner September 3, 2021 20:04

ghost added dev/tooling integration/datadog_checks_dev labels Sep 3, 2021

Fix style

1f70c27

Skip validation on warnings for valid use

238517a

ghost added integration/cloud_foundry_api integration/voltdb labels Sep 3, 2021

hithwen approved these changes Sep 6, 2021

View reviewed changes

ChristineTChen merged commit 3901cbc into master Sep 13, 2021

ChristineTChen deleted the cc/http-warn branch September 13, 2021 18:20