csscomb#387: Fix space-after-opening-brace for empty media queries

DSCS2009 · May 23, 2015 · d6d69a9 · d6d69a9
1 parent 7940b30
commit d6d69a9
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 1 deletion.
diff --git a/lib/options/space-after-opening-brace.js b/lib/options/space-after-opening-brace.js
@@ -23,7 +23,8 @@ module.exports = {
 
         var value = this.getValue('space-after-opening-brace');
 
-        if (node.first().is('space')) {
+        if (node.first() &&
+            node.first().is('space')) {
             node.first().content = value;
         } else if (value !== '') {
             var space = gonzales.createNode({ type: 'space', content: value });

diff --git a/test/options/space-after-opening-brace/issue-387.css b/test/options/space-after-opening-brace/issue-387.css
@@ -0,0 +1 @@
+@media only screen (max-width:479px) {}
diff --git a/test/options/space-after-opening-brace/issue-387.expected.css b/test/options/space-after-opening-brace/issue-387.expected.css
@@ -0,0 +1,2 @@
+@media only screen (max-width:479px) {
+}
diff --git a/test/options/space-after-opening-brace/test.js b/test/options/space-after-opening-brace/test.js
@@ -29,6 +29,11 @@ describe('options/space-after-opening-brace:', function() {
         this.shouldBeEqual('test.css', 'test-3.expected.css');
     });
 
+    it('Issue 387', function() {
+        this.comb.configure({ 'space-after-opening-brace': '\n' });
+        this.shouldBeEqual('issue-387.css', 'issue-387.expected.css');
+    });
+
     it('Should detect no whitespace', function() {
         this.shouldDetect(
             ['space-after-opening-brace'],