Ignore leading combinators

Issue 551
DSCS2009 · Mar 22, 2019 · adcfc01 · adcfc01
1 parent 269e854
commit adcfc01
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 1 deletion.
diff --git a/src/options/space-before-combinator.js b/src/options/space-before-combinator.js
@@ -24,7 +24,10 @@ module.exports = {
 
     ast.traverseByType('combinator', function(combinator, i, parent) {
       var previousNode = parent.get(i - 1);
-      if (previousNode && previousNode.is('space')) {
+
+      if (!previousNode) return;
+
+      if (previousNode.is('space')) {
         previousNode.content = value;
       } else {
         var space = gonzales.createNode({

diff --git a/test/options/space-before-combinator/process/scss/test.expected.scss b/test/options/space-before-combinator/process/scss/test.expected.scss
@@ -0,0 +1,15 @@
+a  >b {
+  color: red;
+
+  &  >c {
+    color: red;
+  }
+}
+
+a {
+  color: red;
+
+  >c {
+    color: red;
+  }
+}
diff --git a/test/options/space-before-combinator/process/scss/test.scss b/test/options/space-before-combinator/process/scss/test.scss
@@ -0,0 +1,15 @@
+a>b {
+  color: red;
+
+  &>c {
+    color: red;
+  }
+}
+
+a {
+  color: red;
+
+  >c {
+    color: red;
+  }
+}
diff --git a/test/options/space-before-combinator/process/test.js b/test/options/space-before-combinator/process/test.js
@@ -32,4 +32,11 @@ describe('Option `space-before-combinator`, process', function() {
       return test.shouldBeEqual('test.css', 'test-3.expected.css');
     });
   });
+
+  describe('scss', function() {
+    it('Should not touch leading combinators', function() {
+      let test = new Test(this, {'space-before-combinator': '  '});
+      return test.shouldBeEqual('test.scss', 'test.expected.scss');
+    });
+  });
 });