Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add paginations in actions list #819

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add paginations in actions list #819

wants to merge 1 commit into from

Conversation

utkarsh-dixit
Copy link
Collaborator

@utkarsh-dixit utkarsh-dixit commented Nov 5, 2024 •
edited by ellipsis-dev bot
Loading

Important

Add pagination support to the actions list by introducing a page parameter in ActionsControllerV2ListActionsData and updating the list method in Actions class.

  • Behavior:
    • Adds page parameter to ActionsControllerV2ListActionsData in types.gen.ts for pagination support.
    • Updates list method in Actions class in actions.ts to include page in query parameters.
  • Misc:
    • Minor import change in actions.ts to include ActionsControllerV2ListActionsData.

This description was created by Ellipsis for e2d1b9f. It will automatically update as commits are pushed.

@vercel Vercel
Copy link

vercel bot commented Nov 5, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2024 8:43am

@sweep-ai Sweep AI
Copy link

sweep-ai bot commented Nov 5, 2024 •
edited
Loading

Hey @utkarsh-dixit, here is an example of how you can ask me to improve this pull request:

@Sweep Add unit tests for the `list` method in `Actions` class to verify:
1. The new `page` parameter is correctly passed through to the query parameters
2. The pagination works with different combinations of parameters (e.g., page only, page with tags, page with useCase, etc.)
3. The default behavior when page is not provided

📖 For more information on how to use Sweep, please read our documentation.

ellipsis-dev[bot]
ellipsis-dev bot reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e2d1b9f in 1 minute and 0 seconds

More details
  • Looked at 44 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. js/src/sdk/models/actions.ts:173
  • Draft comment:
    The GetListActionsData type should include page and limit properties to match the updated query parameters in the list method.
  • Reason this comment was not posted:
    Comment was on unchanged code.

Workflow ID: wflow_HGuSMsCjNcfdBpUS

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-11680492999/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-11680492999/html-report/report.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@utkarsh-dixit