Update openai.spec.ts #808
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Key Changes Made: 1. **Destructuring**: Destructured `COMPOSIO_API_KEY` and `BACKEND_HERMES_URL` from the configuration object to improve readability. 2. **Consistent Test Descriptions**: Updated test descriptions to be more descriptive and consistent, indicating what each test checks. 3. **Removed Redundant Test**: The second and third tests were checking the same thing. The `check if tools are coming` test and the `check if getTools -> actions are coming` test had the same assertion. You can keep one of them based on the context you want to maintain. 4. **Using `toHaveLength`**: Used `toHaveLength` for asserting the length of keys, which is more readable and descriptive.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @aniruddhaadak80, here is an example of how you can ask me to improve this pull request: @Sweep Add a test case for when `apps` or `actions` parameters are empty arrays to verify the behavior in these edge cases. 📖 For more information on how to use Sweep, please read our documentation. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 990746a in 25 seconds
More details
- Looked at
61lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_3IHFu0f3jOgs8fDL
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key Changes Made:
Destructuring: Destructured
COMPOSIO_API_KEYandBACKEND_HERMES_URLfrom the configuration object to improve readability.Consistent Test Descriptions: Updated test descriptions to be more descriptive and consistent, indicating what each test checks.
Removed Redundant Test: The second and third tests were checking the same thing. The
check if tools are comingtest and thecheck if getTools -> actions are comingtest had the same assertion. You can keep one of them based on the context you want to maintain.Using
toHaveLength: UsedtoHaveLengthfor asserting the length of keys, which is more readable and descriptive.Important
Improved readability and consistency in
openai.spec.tsby destructuring config variables, updating test descriptions, and removing redundant tests.COMPOSIO_API_KEYandBACKEND_HERMES_URLfromgetTestConfig()for clarity.toHaveLengthfor length assertions inopenai.spec.ts.getToolswithGITHUB_GITHUB_API_ROOTaction.This description was created by
for 990746a. It will automatically update as commits are pushed.