Update logger.ts #805
Closed
Update logger.ts #805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes Made: 1. Simplified the colorize function by directly using the colors object to get the color function, reducing the repetitive code for setting the timestamp. 2. Added a check in colorize to ensure that only valid levels are colorized, defaulting to the level name if not found.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @aniruddhaadak80, here is an example of how you can ask me to improve this pull request: @Sweep Add unit tests for the `colorize` function to verify: 📖 For more information on how to use Sweep, please read our documentation. |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 362797d in 26 seconds
More details
- Looked at
51lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_IhjJMkWG5HE03tst
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
Please review and add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made:
Simplified the colorize function by directly using the colors object to get the color function, reducing the repetitive code for setting the timestamp.
Added a check in colorize to ensure that only valid levels are colorized, defaulting to the level name if not found.
Important
Simplified
colorizefunction inlogger.tsand added validation for log levels to ensure only valid levels are colorized.colorizefunction inlogger.tsby using thecolorsobject directly to fetch color functions, reducing repetitive code.colorizeto ensure only valid log levels are colorized, defaulting to the level name if not found.This description was created by
for 362797d. It will automatically update as commits are pushed.