-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Developer onboarding notification added #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Changes requested. Reviewed everything up to ea29ff7 in 32 seconds
More details
- Looked at
116lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. .github/workflows/developer_onboarding_notification.yml:4
- Draft comment:
Using 'pull_request_target' can be a security risk if not handled properly. Ensure that the action does not execute untrusted code. - Reason this comment was not posted:
Comment did not seem useful.
2. .github/workflows/developer_onboarding_notification.yml:16
- Draft comment:
Consider using 'actions/checkout@v3' instead of 'v4' unless there's a specific reason to use 'v4'. - Reason this comment was not posted:
Confidence changes required:50%
The action uses 'actions/checkout@v4', but the latest stable version is 'v3'. Using the latest stable version is recommended unless there's a specific reason to use a different one.
Workflow ID: wflow_NbMwS6Hlk3rSFoiN
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| const prCount = parseInt(process.env.PR_COUNT); | ||
| const author = process.env.AUTHOR; | ||
| const mention = 'himanshu-dixit'; | ||
| const prNumber = context.payload.pull_request.number; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Import 'context' from '@actions/github' to use 'context.payload.pull_request.number'.
|
Hey @himanshu-dixit , The pr is ready to be reviewed. please do review it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @himanshu-dixit , I have participated in an opensource competition and it will be really helpful if you can merge this pr. |
Closes #705
Description
This PR introduces a new GitHub Action that automatically posts a comment on a pull request once it has been merged into the main branch.
Important
Adds a GitHub Action to comment on merged PRs with personalized messages based on the author's contribution count.
developer_onboarding_notification.ymlto comment on merged PRs.pull_request_targetevent when PR is closed and merged.AUTHOR,REPO, andOWNER.actions/github-script@v6.himanshu-dixitfor support.This description was created by
for ea29ff7. It will automatically update as commits are pushed.