fix: Pick latest connected account in get_connection() method #1569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekpatil4
requested review from
angrybayblade and
kaavee315
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
LGTM 👍 |
kaavee315
approved these changes
Apr 24, 2025
Comment on lines
+345
to
+346
| latest_account = connected_account | ||
| break |
Contributor
There was a problem hiding this comment.
You need to sort the list of connected account by the creation date in reverse fir this logic to work
Contributor
|
marking stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sweep Summary
Fixed the
get_connection()method in the Composio SDK client to correctly select the latest connected account by taking the first matching account instead of comparing creation dates.python/composio/client/__init__.pyby removing the datetime comparison and using the first matching account as the latest one.breakstatement to exit the loop once a matching account is found, improving performance.Ask Sweep AI questions about this PR
get_connection()method to get the latest connected account ID