fix: add billcom_auth scheme to sdk #1502
Conversation
alt-glitch
requested review from
angrybayblade,
himanshu-dixit,
kaavee315,
plxity and
utkarsh-dixit
as code owners
|
Your trial period has expired. To continue using this feature, please upgrade to a paid plan. You can upgrade your account here - https://entelligence.ai/manage/billing |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alt-glitch
requested review from
himanshu-dixit and
sjd9021
and removed request for
angrybayblade,
himanshu-dixit,
kaavee315,
plxity and
utkarsh-dixit
| "GOOGLEADS_AUTH", | ||
| "NO_AUTH", | ||
| "CALCOM_AUTH", | ||
| "BILLCOM_AUTH" |
There was a problem hiding this comment.
Consider adding a brief comment explaining what BILLCOM_AUTH is and its use case. This will help future maintainers understand the purpose of this authentication scheme.
| "GOOGLEADS_AUTH", | ||
| "NO_AUTH", | ||
| "CALCOM_AUTH", | ||
| "BILLCOM_AUTH" |
There was a problem hiding this comment.
Consider adding BILLCOM_AUTH to the docstring of AuthSchemeType to maintain consistency with other auth schemes in the type definition.
|
This comment was generated by github-actions[bot]! JS SDK Coverage Report📊 Coverage report for JS SDK can be found at the following URL: 📁 Test report folder can be found at the following URL: |
Code Review SummaryChanges Overview
Suggestions
Code Quality: ✅ Good
Testing Considerations
Overall, the changes look clean and well-structured. Main suggestion is to improve documentation for future maintainability. |
|
marking stale |
No description provided.