feat: short name for mcp server in cursor and bump version to 1.0.5 #1478
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![entelligence-ai-pr-reviews[bot]](https://avatars.githubusercontent.com/in/932812?s=60&v=4){kind=small}
|
|
||
| try { | ||
| const newKey = url.split('/').slice(3).join('/').replace(/\//g, '-'); | ||
| const newKey = url.split('/').slice(3)[0] + '_composio'; |
There was a problem hiding this comment.
The change breaks URL parsing by only taking the first segment after the domain instead of the full path. This will cause incorrect configuration keys for nested paths.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| const newKey = url.split('/').slice(3)[0] + '_composio'; | |
| const newKey = url.split('/').slice(3).join('/') + '_composio'; |
|
|
||
| try { | ||
| const newKey = url.split('/').slice(3).join('/').replace(/\//g, '-'); | ||
| const newKey = url.split('/').slice(3)[0] + '_composio'; |
There was a problem hiding this comment.
Consider adding validation for the URL structure before accessing the first segment. The current implementation might throw an error if url.split('/').slice(3) returns an empty array. A safer approach would be:
const segments = url.split('/').slice(3);
if (segments.length === 0) {
throw new Error('Invalid URL format');
}
const newKey = segments[0] + '_composio';| const newKey = url.split('/').slice(3).join('/').replace(/\//g, '-'); | ||
| const newKey = url.split('/').slice(3)[0] + '_composio'; | ||
|
|
||
| cursorConfig.mcpServers[newKey] = sseConfig; |
There was a problem hiding this comment.
Consider adding a check for potential key collisions. Since we're now using only the first segment of the URL path, there's a possibility that different URLs with the same first segment could overwrite each other's configurations. Example:
if (cursorConfig.mcpServers[newKey]) {
console.log(chalk.yellow(`⚠️ Warning: Overwriting existing configuration for ${newKey}`));
}
Code Review SummaryChanges Overview
Potential Issues
Suggestions
Overall AssessmentThe changes are generally good and improve the user experience by creating shorter, more manageable server keys. The version bump is appropriate for this feature addition. However, adding the suggested validations would make the code more robust. Rating: 7/10 - Good changes but needs additional error handling and validation. |
No description provided.