Skip to content

Fix update_component tool to surface errors when updates fail #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CoderGamester merged 4 commits into from
Jul 30, 2025
Merged

Fix update_component tool to surface errors when updates fail #70

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9745885
feat: update_component will now return an error with proper message i…
wojciech-golowkow Jul 30, 2025
6d63c6b
better var name
wojciech-golowkow Jul 30, 2025
15f7dea
correctly handling componentData
wojciech-golowkow Jul 30, 2025
137705e
second setDirty only when component data succesfully updated
wojciech-golowkow Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
feat: update_component will now return an error with proper message i… 
…f it tries to update a field that does not exist
  • Loading branch information
@wojciech-golowkow
wojciech-golowkow committed Jul 30, 2025
commit 9745885a827e80fe9dda92ca660c9de3859ddf01
42 changes: 31 additions & 11 deletions Editor/Tools/UpdateComponentTool.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,27 @@ public override JObject Execute(JObject parameters)
McpLogger.LogInfo($"[MCP Unity] Added component '{componentName}' to GameObject '{gameObject.name}'");
}

string errorMessage = "";
bool success = false;
// Update component fields
if (componentData != null && componentData.Count > 0)
{
UpdateComponentData(component, componentData);
success = UpdateComponentData(component, componentData, out errorMessage);
}

// If update failed, return error
if (!success)
{
if (wasAdded)
{
return McpUnitySocketHandler.CreateErrorResponse(
$"Successfully added component '{componentName}' to GameObject '{gameObject.name}' BUT\n" +
errorMessage, "component_error");
}
else
{
return McpUnitySocketHandler.CreateErrorResponse(errorMessage, "update_error");
}
}

// Ensure changes are saved
Expand Down Expand Up @@ -236,19 +253,21 @@ private Type FindComponentType(string componentName)
/// <param name="component">The component to update</param>
/// <param name="componentData">The data to apply to the component</param>
/// <returns>True if the component was updated successfully</returns>
private bool UpdateComponentData(Component component, JObject componentData)
private bool UpdateComponentData(Component component, JObject componentData, out string errorMessage)
{
errorMessage = "";
if (component == null || componentData == null)
{
errorMessage = "Component or component data is null";
return false;
}

Type componentType = component.GetType();
bool anySuccess = false;
bool gotFailure = false;

// Record object for undo
Undo.RecordObject(component, $"Update {componentType.Name} fields");

// Process each field in the component data
foreach (var property in componentData.Properties())
{
Expand All @@ -269,18 +288,19 @@ private bool UpdateComponentData(Component component, JObject componentData)
{
object value = ConvertJTokenToValue(fieldValue, fieldInfo.FieldType);
fieldInfo.SetValue(component, value);
anySuccess = true;
continue;
}
else
{
McpLogger.LogWarning($"Field '{fieldName}' not found on component '{componentType.Name}'");
errorMessage = $"Field '{fieldName}' not found on component '{componentType.Name}'";
McpLogger.LogError(errorMessage);
gotFailure = true;
}
}
return anySuccess;

return !gotFailure;
}

/// <summary>
/// Convert a JToken to a value of the specified type
/// </summary>
Expand Down