Fix player lifetime stats #21607
Merged
Fix player lifetime stats #21607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will it change something in the lua |
Store as member of player class instead of global object. Access directly (will be written by various code all over the place, a setter/modifier function seems unnecessary). Names it `lifetime_stats` to distinguish it more clearly from the other stats like hinger, pain.
This allows to skip resetting in the constructor (which makes no sense anyway, why would one *re*set a freshly constructed object). And the `reset` function now simply assigns a default constructed object. The behaviour is essentially unchanged.
The constructor of the member is implicitly called and does the resetting on its own. The reset function is not needed at all.
|
I added it to be exported to Lua. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store as member of
playerinstead of global object.Access directly (will be written by various code all over the place, a setter/modifier function seems unnecessary).
Name it
lifetime_statsto distinguish it more clearly from the other stats like hunger, pain.Remove
stats::resetas it's not needed, instead set initial values of members ofstats.