fix: make bringToFront optional in select_page #668
+33
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OrKoN
force-pushed
the
orkon/fix-select-page
branch
from
096a86c to
c6a6667
Compare
OrKoN
force-pushed
the
orkon/fix-select-page
branch
from
c6a6667 to
85a745c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bringToFront() not only brings the tab to front in the browser but also the browser window itself. This PR fixes the issue by making the call to bringToFront() optional allowing agents to bring a tab to the user's attention if needed but not always. To mitigate the risk of selected page that is in the background being throttled, this PR implements emulation of the focused page to make background tabs run as usual.