-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to handle the NodeJS 16 dependency #9921
Conversation
Post-merge notesWe can close the issue/PR below after this PR is merged. The INSTALL instruction should be modified because it will no longer require pre-installation process. |
@wjblanke @altendky ChangelogChanged
Fixed
Added
|
Found out that Ubuntu18 which is ec2 instance(t2.medium) with 4GB RAM struggles to process GUI build. Will do some researching how much RAM is sufficient to build GUI. |
In my observation,
|
7f961b8
to
1c47e00
Compare
I tested Ubuntu 18 and Rocky OS 8. Both worked fine, although those were not an entirely new OS install (I had installed previous versions of chia) Centos 7 doesn't work as there is apparently no python 3.9 package and this causes a failure: |
@emlowe Thanks for testing. CentOS7, I'll check and fix the script. IIRC CentOS7 even do not have |
I don't think I've ever installed Centos 7 and not had |
IIRC CentOS7 in docker container used in CI runner for the rpm installer showed error that |
I've found that installing Python on CentOS7 does not come easy. You cannot simply |
I didn't add any CentOS docker (CLI) installer tests exactly because they seemed to not provide new enough packages. Isn't CentOS dead anyways? Was Rocky, as you reference Earle, the replacement? Anyways, not a clean install here but worked straight away on Ubuntu 20.04. Thanks for all the work on this. I guess I'll go look at adding Rocky to the (CLI) installer test set. |
I had earlier made the call that CentOS 8 was as far back as we need to go. I think it's safe to return to that thought. |
For reference on CentOS installs. https://github.com/Chia-Network/chia-blockchain/wiki/INSTALL#centosred-hatfedora |
I've updated |
Centos moved from a downstream model (Now called Centos Linux) to an upstream model and rebranded as Centos Stream Centos Linux 7 is supported until 2024 Centos Stream 8 is supported until 2024, but because of the change in the model, this release gets patches continuously before they go into RHEL - there I don't think anyone is using it as they used to since it is upstream of RHEL it is no longer a bug-for-bug proxy for RHEL. Centos Stream 8 has no minor patch versions, as patches are just rolled into it whenever Centos Stream 9 is also supported until 2027 Rocky 8 is a community-driven response to this change to make a release that is downstream of RHEL and is bug-for-bug compatible with RHEL 8 and is supported until 2029 Here endeth the saga that is Centos. |
* Added n as a local npm dependency
…ll bc -y` even if `bc` is installed already
cea2b6f
to
5632597
Compare
@wjblanke @emlowe @altendky |
Thanks for keeping this going. Whatever you have added support for in chia-blockchain/.github/workflows/test-install-scripts.yml Lines 60 to 107 in 2314f47
|
@altendky Added centos7/8 docker urls to the install test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - nice work!
Draft for:
n
install for all platforms, not just Ubuntustable
.n
directory before installing to it?