Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to legacy-keyring as the extra name so it works #17770

Merged
merged 1 commit into from
Mar 25, 2024
Merged

switch to legacy-keyring as the extra name so it works #17770

merged 1 commit into from
Mar 25, 2024

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Mar 22, 2024 •
edited
Loading

Purpose:

Current Behavior:

https://github.com/Chia-Network/chia-blockchain/actions/runs/8393134572/job/22987463242#step:12:198

WARNING: chia-blockchain 2.2.2.dev242 does not provide the extra 'legacy-keyring'

New Behavior:

https://github.com/Chia-Network/chia-blockchain/actions/runs/8393857772/job/22989809717?pr=17770#step:12:1

no warning

Testing Notes:

@altendky altendky requested a review from a team as a code owner March 22, 2024 17:03
@altendky altendky added the Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog label Mar 22, 2024
@altendky altendky requested a review from emlowe March 25, 2024 13:05
@pmaslana pmaslana merged commit 6adb099 into main Mar 25, 2024
289 of 290 checks passed
@pmaslana pmaslana deleted the legacy_keyring_extra branch March 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlowe emlowe emlowe approved these changes

Assignees
No one assigned
Labels
Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@altendky @emlowe @pmaslana