Skip to content

reorder gui install command instructions in install.sh/ps1 #14180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wallentx merged 2 commits into from
Dec 19, 2022
Merged

reorder gui install command instructions in install.sh/ps1 #14180

wallentx merged 2 commits into from
Dec 19, 2022

Conversation

@altendky
Copy link
Contributor

@altendky altendky commented Dec 17, 2022

"To install the GUI type 'sh install-gui.sh' after '. ./activate'."
somoene should really rephrase that

Then a sarcasm fail...

"Test the footgun trigger, after you clear the rounds and enable the safety." See? Ordering like that is totally fine. Not really sure what you're concerned about.

@altendky altendky added Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog Cleanup Code cleanup labels Dec 17, 2022
@altendky altendky marked this pull request as ready for review December 18, 2022 19:45
@altendky altendky requested a review from a team as a code owner December 18, 2022 19:45
@altendky altendky requested a review from emlowe December 18, 2022 19:45
@wallentx wallentx merged commit 419342e into main Dec 19, 2022
@wallentx wallentx deleted the do_second_after_do_first branch December 19, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arvidn arvidn arvidn approved these changes

@emlowe emlowe Awaiting requested review from emlowe

+1 more reviewer

@paninaro paninaro paninaro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Cleanup Code cleanup Fixed Required label for PR that categorizes merge commit message as "Fixed" for changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@altendky @paninaro @arvidn @wallentx