Skip to content

tools: Implement and test tools/legacy_keyring.py #13947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wallentx merged 3 commits into from
Dec 4, 2022
Merged

tools: Implement and test tools/legacy_keyring.py #13947

wallentx merged 3 commits into from
Dec 4, 2022

Conversation

@xdustinface
Copy link
Contributor

@xdustinface xdustinface commented Nov 18, 2022

Adds a tool which allows to access to the legacy keyring after #13398 has been merged which drops the legacy keyring support from all production code.

To use the tool (or run the tests) on linux it's additionally required to run install.sh with the -l flag to install the legacy keyring dependency.

Help message

Usage: legacy_keyring.py [OPTIONS] COMMAND [ARGS]...

  Manage the keys in the legacy keyring.

Options:
  --help  Show this message and exit.

Commands:
  clear  Remove all keys
  show   Show all available keys

@xdustinface xdustinface added the Added Required label for PR that categorizes merge commit message as "Added" for changelog label Nov 18, 2022
arvidn
arvidn reviewed Nov 18, 2022
View reviewed changes
@xdustinface xdustinface reopened this Nov 18, 2022
@xdustinface xdustinface force-pushed the pr-tools-legacy-keyring branch 2 times, most recently from 823239e to a5fb4eb Compare November 19, 2022 11:04
@xdustinface xdustinface force-pushed the pr-tools-legacy-keyring branch from a5fb4eb to 84e95fd Compare November 20, 2022 22:28
@xdustinface xdustinface marked this pull request as ready for review November 20, 2022 22:29
@xdustinface xdustinface requested a review from a team as a code owner November 20, 2022 22:29
paninaro
paninaro reviewed Dec 2, 2022
View reviewed changes
paninaro
paninaro approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@paninaro paninaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wallentx wallentx merged commit b916275 into Chia-Network:main Dec 4, 2022
@wallentx wallentx added the Tools label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arvidn arvidn Awaiting requested review from arvidn

@altendky altendky Awaiting requested review from altendky

1 more reviewer

@paninaro paninaro paninaro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Added Required label for PR that categorizes merge commit message as "Added" for changelog Tools

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@xdustinface @paninaro @arvidn @wallentx