-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimized a chance where sudo
prompts users for password
#13219
Conversation
…ts users for password
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The openssl bit was specifically intended to trigger an update, not just an install when missing. It was added when there was a critical ssl update a few months ago. I'm not sure if that is still considered important.
Thanks for the work on this!
As python just uses the system installed OpenSSL we want to be forcing an upgrade to the most current OpenSSL on an ongoing basis. This will certainly not be the last time OpenSSL has a vulnerability... |
I had initially proposed a CLI flag to skip the system stuff. I don't want to be entering my password into scripts all the time. I also don't want to wait around for apt all the time. A CLI flag would leave the option for default users to still get the baby sitting we have here. Someone recently got banned from apt connections or something and so they couldn't use the installer for a few hours. That's kind of the top level perspective that brought up this topic. I wonder if the full suite of mature installers at this time has any bearing on the trade offs here. |
@hoffmang9 @altendky
|
I think to check if openssl is old I would basically expect to do an |
OpenSSL will be updated only when version < 3.0.2 or 1.1.1n or 1.0.2zd is installed. |
I thought Gene wanted us to do that. Otherwise we have to push an updated |
Overhauled entire construct of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea of a skip option
If
python
,sqlite
,openssl
are already available, we don't need to runsudo apt install xxx
.This PR tries to minimize the chance to prompt users for their password.