simplify install.sh ubuntu version tracking #11288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 23, 2022
emlowe
added
1.3.5-cherrypick
and removed
ready_to_merge
wallentx
pushed a commit
that referenced
this pull request
Apr 28, 2022
* simplify install.sh ubuntu version tracking * quotes for bash * undo some unintended changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative simplification to #11279. This one is intended to not change any corner cases, just simplify the code in preparation for extending to support Ubuntu 22.04.
Draft for:
install.shtest matrix. For example, they provide Python 3.10 forpython3in their 21 version unlike Ubuntu. Add Linux Mint to test matrix #11295