Skip to content

Conversation

@altendky
Copy link
Contributor

@altendky altendky commented Feb 7, 2022

Draft for:

  • install.sh should handle installing Python, not the GitHub Actions job.

@altendky altendky marked this pull request as ready for review February 7, 2022 02:51
@altendky altendky requested a review from wallentx February 7, 2022 03:32
wallentx
wallentx previously approved these changes Feb 8, 2022
Copy link
Contributor

@wallentx wallentx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@wjblanke
Copy link
Contributor

was going to merge but there is a conflict unfortunately

@wallentx wallentx self-requested a review February 14, 2022 23:32
Copy link
Contributor

@wallentx wallentx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@wjblanke wjblanke merged commit bd845f5 into main Feb 15, 2022
@wjblanke wjblanke deleted the test_cli_installer_on_rocky branch February 15, 2022 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants