more set -o errexit (#10468)

* more set -o errexit -o pipefail * no pipefail, too fancy for dash at least...
Chia-Network · Mar 17, 2022 · 161a838 · 161a838
1 parent 144c4d1
commit 161a838
Show file tree

Hide file tree

Showing 11 changed files with 22 additions and 5 deletions.
diff --git a/build_scripts/build_linux_deb.sh b/build_scripts/build_linux_deb.sh
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -o errexit
+
 if [ ! "$1" ]; then
   echo "This script requires either amd64 of arm64 as an argument"
 	exit 1

diff --git a/build_scripts/build_linux_rpm.sh b/build_scripts/build_linux_rpm.sh
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -o errexit
+
 if [ ! "$1" ]; then
   echo "This script requires either amd64 of arm64 as an argument"
 	exit 1

diff --git a/build_scripts/build_macos.sh b/build_scripts/build_macos.sh
@@ -1,6 +1,6 @@
 #!/bin/bash
 
-set -euo pipefail
+set -o errexit -o nounset
 
 pip install setuptools_scm
 # The environment variable CHIA_INSTALLER_VERSION needs to be defined.

diff --git a/build_scripts/build_macos_m1.sh b/build_scripts/build_macos_m1.sh
@@ -1,6 +1,6 @@
 #!/bin/bash
 
-set -euo pipefail
+set -o errexit -o nounset
 
 pip install setuptools_scm
 # The environment variable CHIA_INSTALLER_VERSION needs to be defined.

diff --git a/build_scripts/clean-runner.sh b/build_scripts/clean-runner.sh
@@ -1,6 +1,8 @@
 #!/bin/bash
 # Cleans up files/directories that may be left over from previous runs for a clean slate before starting a new build
 
+set -o errexit
+
 PWD=$(pwd)
 
 rm -rf ../venv || true

diff --git a/chia/wallet/puzzles/recompile-all.sh b/chia/wallet/puzzles/recompile-all.sh
@@ -2,6 +2,8 @@
 
 # This hack is a quick way to recompile everything in this directory
 
+set -o errexit
+
 #BASE_DIR=`pwd | dirname`
 
 FILES=$(ls ./*.clvm)

diff --git a/install-gui.sh b/install-gui.sh
@@ -1,5 +1,7 @@
 #!/bin/bash
-set -e
+
+set -o errexit
+
 export NODE_OPTIONS="--max-old-space-size=3000"
 
 SCRIPT_DIR=$(cd -- "$(dirname -- "$0")"; pwd)

diff --git a/install-timelord.sh b/install-timelord.sh
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -o errexit
+
 if [ -z "$VIRTUAL_ENV" ]; then
   echo "This requires the chia python virtual environment."
   echo "Execute '. ./activate' before running."

diff --git a/install.sh b/install.sh
@@ -1,5 +1,6 @@
 #!/bin/bash
-set -e
+
+set -o errexit
 
 USAGE_TEXT="\
 Usage: $0 [-d]

diff --git a/run-py-tests.sh b/run-py-tests.sh
@@ -1,5 +1,7 @@
 #!/bin/bash
 
+set -o errexit
+
 python3 -m venv venv
 # shellcheck disable=SC1091
 . ./activate

diff --git a/start-gui.sh b/start-gui.sh
@@ -1,5 +1,7 @@
 #!/bin/bash
-set -e
+
+set -o errexit
+
 export NODE_OPTIONS="--max-old-space-size=3000"
 
 SCRIPT_DIR=$(cd -- "$(dirname -- "$0")"; pwd)