Implement prepend signatures in c++/python, update python implementation, fix bug #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariano54
changed the title
…prependSignatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new type of signature, the PrependSignature. This is generated by prepending the public key to the message hash (and hashing again). The purpose of this is to protect against the rogue public key attack, without requiring additional metadata of how signatures where aggregated.
The construction is:
prepend_m = hash256(pk + hash256(m))).
These signatures are not compatible, which is why a new class is added, and a new bit is used in the serialization.
Also the prepend signature is added to the pure python implementation, and some refactoring is done there to bring it up to speed.