Update contrib/relic to upstream 94154a8b77e1+https://github.com/relic-toolkit/relic/pull/88 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
excellent thanks, I was going to do the same thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes:
If relic-toolkit/relic#88 gets merged in before this PR, I'll update the PR accordingly.
I did this update manually by copying the latest relic sources into contrib/relic and then picking the changes into git. I hope I didn't make any errors, especially in regard to the changes that were performed in parallel in this repository. Please review.
In the future, I'd suggest to perform such updates by creating a patch inside the relic repository:
and then applying that patch to contrib/relic. The commit message should then include the commit id of relic's master so that next time you know which version to diff against.