Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implicitly converting 'INTEGER' to 'STRING' type warnings. #263

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Fix implicitly converting 'INTEGER' to 'STRING' type warnings. #263

merged 1 commit into from
Aug 4, 2021

Conversation

AmineKhaldi
Copy link
Contributor

No description provided.

hoffmang9
hoffmang9 approved these changes Aug 4, 2021
View reviewed changes
Copy link
Member

@hoffmang9 hoffmang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

@hoffmang9 hoffmang9 merged commit ecf77cc into Chia-Network:main Aug 4, 2021
@AmineKhaldi AmineKhaldi deleted the fix_cmake_warnings branch August 5, 2021 09:54
UdjinM6 pushed a commit to UdjinM6/bls-signatures that referenced this pull request Dec 1, 2021
@AmineKhaldi @UdjinM6
Fix implicitly converting 'INTEGER' to 'STRING' type warnings. (Chia-…
5a2129d 
…Network#263)
@Fuzzbawls Fuzzbawls mentioned this pull request Apr 15, 2023
Merged
Fuzzbawls added a commit to PIVX-Project/bls-signatures that referenced this pull request Apr 18, 2023
@Fuzzbawls
Merge #20: CMake: Squelch implicit conversion warnings
1446804 
4581ffa CMake: Squelch implicit conversion warnings (Fuzzbawls)

Pull request description:

  A number of caches were being implicitly converted from `INTEGER` to `STRING`, which triggers a warning in CMake. Remedy the situation by explicitly storing those caches as `STRING` to begin with.

  Ref: Chia-Network#263

  Extracted from: #12

ACKs for top commit:
  panleone:
    utACK 4581ffa
  Liquid369:
    ACK 4581ffa

Tree-SHA512: f45a341b40b02f1b894d785ad249d324b1a6e55f3954749ca8e2bc30cf87d10df70ab462063de4db0048ea5ef67a7c48a402b9ae1b3fc400c5684dd03c93040f
@ChiaAutomation ChiaAutomation mentioned this pull request Jun 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoffmang9 hoffmang9 hoffmang9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmineKhaldi @hoffmang9