Multiple (cross-)build related fixes and additions #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"#if BLSALLOC == sodium" for some reason evaluates to true and thus sodium is used even though it is not present.
/dev/[u]dev is not present on Windows.
When cross-compiling on Debian Stretch, compilation fails because Wincrypt.h can't be found because includes are case-sensitive on Linux.
Required for cross-compilation.
PastaPastaPasta
added a commit
to PastaPastaPasta/bls-signatures
that referenced
this pull request
Nov 28, 2021
…k#24) util.hpp: In static member function ‘static std::string bls::Util::HexStr(const uint8_t*, size_t)’: util.hpp:62:25: warning: comparison of integer expressions of different signedness: ‘int’ and ‘size_t’ {aka ‘long unsigned int’} [-Wsign-compare] 62 | for (int i=0; i < len; ++i)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commits. If something should not be included as part of this PR, I can remove it again and put it into another specialized PR.