Updates to cmake to work around missing statics #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also made a small change for 32-bit systems (which are actually pretty rare now - most common Linux distros don't support them anymore). |
UdjinM6
pushed a commit
to UdjinM6/bls-signatures
that referenced
this pull request
Dec 1, 2021
* Updates to cmake to work around missing statics * Add in 32bit check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup CMAKE to require C++17 - this helps with places where the default compiler does not (Centos 7) and errors out early
Also, configure to avoid making the "combined custom" library libbls.a if the platform does not have the static versions of libgmp or libsodium. The library and test programs still work, however, because the dynamic version will be linked to the executable (ie runtest, etc)
This does mean on such a system that when using libbls.a one does need to link to the dynamic libraries, but this is preferable to not building at all and throwing strange errors. This should fix issue #225