Revive javascript bindings and port python tests to javascript. #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll work, reusing the python tests via brython would help keep things in sync in the future)
…s the naming from python and is running some very lightly ported test code.
UdjinM6
pushed a commit
to UdjinM6/bls-signatures
that referenced
this pull request
Dec 1, 2021
…-Network#212) * Building, replicated deletions from c6010c8, need to sync API (if it'll work, reusing the python tests via brython would help keep things in sync in the future) * General house cleaning and reorganization on js wrappers. Now reflects the naming from python and is running some very lightly ported test code. * test_schemes: All tests passed. * More tests * Feature parity with test.py * Finish mostly parity with python API * Some nicening * Remove diagnostic * Fix broken script * The move constructor isn't strictly needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The javascript bindings that were previously in this code followed an API that appears to have been withdrawn in revision c6010c8, so this PR brings them into fairly close parity with the python bindings.
A few liberties were taken with naming and capitalization to follow javascript idia more closely, and the tests in test.py were ported.
CMake files have been modified to refer to relic in its new build location as cmake presents it and a build script emsdk_build.sh has been provided which uses emsdk to build the js library and bindings, saving some complexity.
A convenience script for running the javascript tests is provided.