Use malloc instead of dynamic allocation on-stack in pairing functions #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it's a good idea, but relic library doesn't use malloc almost anywhere, it seems like it's a design decision? Have you run the benchmarks/tests with this, does everything run properly? What about valgrind? |
|
Will run the tests later with valgrind and then report back |
|
Benchmark and tests run without errors. Valgrind also reported no issues. I created an issue in relic to clarify if this would be allowed in upstream. |
mariano54
reviewed
Sep 19, 2018
contrib/relic/src/pp/relic_pp_map.c
Outdated
| bn_t n; | ||
| int i, j; | ||
|
|
||
| bn_null(n); | ||
|
|
||
| _p = malloc(sizeof(ep_t) * m); | ||
| _q = malloc(sizeof(ep_t) * m); | ||
| t = malloc(sizeof(ep2_t) * m); |
There was a problem hiding this comment.
t should be ep_t and _q should be ep2_t
When these are called with thousands of pairings, dynamic allocation on the stack results in stack overflows, leading to crashes. Better to use heap allocation here.
jonspock
reviewed
Sep 20, 2018
mariano54
approved these changes
Sep 21, 2018
PastaPastaPasta
pushed a commit
to PastaPastaPasta/bls-signatures
that referenced
this pull request
Oct 22, 2021
…e` (Chia-Network#20) * src: Add ExtendedPublicKey, ExtendedPrivateKey and ChainCode * test: Add "Legacy HD" keys tests * Convert seeds to Bytes Co-authored-by: UdjinM6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description from commit:
If this is merged into this repo, I'll also create a PR into the relic project.