Ietf #119

mariano54 · 2020-06-29T12:43:45Z

Making this pull request so I can see all the changes and start reviewing.

mariano54

Wrote some comments, the scheme API is good. I need to review the implementation details a little bit more. Apart from addressing the comments, I think the following should be done:

migrate old C++ tests to new format
migrate old python tests to new format
Add some IETF test cases / vectors (https://github.com/algorand/bls_sigs_ref/tree/master/python-impl)
HD keys using ethereum spec including test vectors: https://eips.ethereum.org/EIPS/eip-2333
Get automated CI tests passing and fix merge conflicts
Add an alias for PublicKey to g1 and Signature to G2 to make usage simpler
Update README.md and SPEC.md
KeyGen algorithm from IETF spec

mariano54 · 2020-07-02T08:36:48Z

src/bls.cpp

    Util::secureAllocCallback = allocCb;
    Util::secureFreeCallback = freeCb;
 }

+/*
 void BLS::HashPubKeys(bn_t* output, size_t numOutputs,


Remove if not in use

mariano54 · 2020-07-02T08:47:11Z

src/elements.cpp

+    } else if (bytes[0] & 0x80) {
+        uncompressed[0] = 0x03;   // Insert extra byte for Y=1
+        uncompressed[1] &= 0x7f;  // Remove initial Y bit
+    } else {


We should throw an error if the serialization is invalid in my opinion. We want to make point have a canonical encoding consistent with the IETF spec.

There are only three valid encodings:
100 (0x80): A compressed point not at infinity, and y is the lexicographically greater value
101 (0xa0): A compressed point not at infinity, and y is the lexicographically lesser value
110 (0xc0): A compressed point at infinity.

https://github.com/zkcrypto/pairing/blob/master/src/bls12_381/README.md#serialization
Also we should add a test case for each case.

mariano54 · 2020-07-02T08:50:54Z

src/elements.hpp

+    static void CompressPoint(uint8_t *result, const gt_t *point);
+};
+
+class BNWrapper {


Where is this used?

mariano54 · 2020-07-02T08:53:30Z

src/elements.cpp

+    G2Element ele = G2Element();
+    uint8_t uncompressed[G2Element::SIZE + 1];
+    std::memcpy(uncompressed + 1, bytes, G2Element::SIZE);
+    if (bytes[0] == 0xc0 && bytes[48] == 0xc0) {  // representing infinity


Same as G1, enforce serialization is correct and add test case

mariano54 · 2020-07-02T08:59:25Z

src/privatekey.hpp

@@ -51,24 +55,55 @@ friend class Threshold;

    ~PrivateKey();

-    PublicKey GetPublicKey() const;
+    // PublicKey GetPublicKey() const;


remove comment

mariano54 · 2020-07-02T09:09:07Z

src/schemes.hpp

+
+public:
+    // static PrivateKey KeyGen(... ikm);  TODO
+    static vector<uint8_t> SkToPk(const PrivateKey &seckey);


This depends on the scheme. Maybe rename? Also why is this not in the PrivateKey class instead?

mariano54 · 2020-07-02T09:10:05Z

src/schemes.hpp

+
+    static G1Element SkToG1(const PrivateKey &seckey);
+
+    static vector<uint8_t> Sign(


I think we should remove this, we can always call G2Element.serialize() right? What's the point of adding the extra method?

mariano54 · 2020-07-02T09:22:54Z

src/elements.cpp

+
+G2Element G2Element::FromMessage(
+    const std::vector<uint8_t>& message,
+    const uint8_t* dst,


What is the user supposed to pass in here for dst? This is confusing

mariano54 · 2020-07-02T09:24:47Z

src/test-bench.cpp

-    benchAggregateSigsSecure();
-    benchAggregateSigsSimple();
-    benchDegenerateTree();
+    // benchSigs();


mariano54 · 2020-07-02T09:24:56Z

src/test.cpp

        uint8_t seed1[5] = {1, 2, 3, 4, 5};
        uint8_t seed2[6] = {1, 2, 3, 4, 5, 6};
        uint8_t message1[3] = {7, 8, 9};
-        
+
        PrivateKey sk1 = PrivateKey::FromSeed(seed1, sizeof(seed1));
        PublicKey pk1 = sk1.GetPublicKey();
        Signature sig1 = sk1.Sign(message1, sizeof(message1));


Uncomment and fix tests

* delete old relic submodule * git submodule add chia's relic * remove travis * bring the ci forward 2 months * bring setup.py forward * add flake8 ini * add mypi.ini * first attempt at FetchContent chia-relic-src * Get cmake almost there * Final cmake fixes * Add lgtm.yml

lgtm-com · 2020-07-10T01:02:24Z

This pull request introduces 2 alerts and fixes 5 when merging 262c463 into f4ffccd - view on LGTM.com

new alerts:

1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
1 for Accidental rethrow

fixed alerts:

3 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Catching by value

lgtm-com · 2020-07-10T02:11:50Z

This pull request introduces 2 alerts and fixes 8 when merging c3cf028 into f4ffccd - view on LGTM.com

new alerts:

1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
1 for Accidental rethrow

fixed alerts:

3 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-10T04:47:54Z

This pull request introduces 2 alerts and fixes 8 when merging 9a983a2 into f4ffccd - view on LGTM.com

new alerts:

1 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
1 for Accidental rethrow

fixed alerts:

3 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-10T05:06:40Z

This pull request introduces 1 alert and fixes 8 when merging b8d2880 into f4ffccd - view on LGTM.com

new alerts:

1 for Accidental rethrow

fixed alerts:

3 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-10T05:22:46Z

This pull request introduces 1 alert and fixes 8 when merging 3bbedbb into f4ffccd - view on LGTM.com

new alerts:

1 for Accidental rethrow

fixed alerts:

3 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-10T05:40:31Z

This pull request introduces 1 alert and fixes 8 when merging 2e41ded into f4ffccd - view on LGTM.com

new alerts:

1 for Accidental rethrow

fixed alerts:

3 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-12T23:14:57Z

This pull request fixes 8 alerts when merging 049a6fd into f4ffccd - view on LGTM.com

fixed alerts:

3 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-13T03:17:17Z

This pull request fixes 8 alerts when merging 11fe38a into f4ffccd - view on LGTM.com

fixed alerts:

3 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-13T05:38:01Z

This pull request fixes 9 alerts when merging 502f981 into f4ffccd - view on LGTM.com

fixed alerts:

4 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-13T06:01:12Z

This pull request fixes 9 alerts when merging a97974c into f4ffccd - view on LGTM.com

fixed alerts:

4 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-13T06:30:29Z

This pull request fixes 9 alerts when merging 9a4ee51 into f4ffccd - view on LGTM.com

fixed alerts:

4 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

…into ietf

lgtm-com · 2020-07-13T08:47:52Z

This pull request fixes 9 alerts when merging 3570dc2 into f4ffccd - view on LGTM.com

fixed alerts:

4 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-13T09:10:05Z

This pull request fixes 9 alerts when merging 781f0b7 into f4ffccd - view on LGTM.com

fixed alerts:

4 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-14T08:05:03Z

This pull request fixes 9 alerts when merging 963e618 into f4ffccd - view on LGTM.com

fixed alerts:

4 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

…into ietf

lgtm-com · 2020-07-14T10:19:17Z

This pull request fixes 9 alerts when merging a972a3e into f4ffccd - view on LGTM.com

fixed alerts:

4 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

lgtm-com · 2020-07-14T17:02:39Z

This pull request fixes 9 alerts when merging 3c105e6 into f4ffccd - view on LGTM.com

fixed alerts:

4 for Inconsistent definition of copy constructor and assignment ('Rule of Two')
2 for Except block handles 'BaseException'
2 for Catching by value
1 for Unused import

hoffmang9

Going ahead and merging into master in anticipation of the 1.8 release

Alex Wice added 4 commits April 20, 2020 15:42

wip schemes

bd1999a

wip: all schemes tests pass

7952910

del relic in prep for submodule add

21005d2

add relic submodule, major wip commit with basic functionality

b8196bf

mariano54 commented Jul 2, 2020

View reviewed changes

Alex Wice and others added 9 commits July 9, 2020 12:15

wip really bad commit with lots of garbage

9bef6d7

manual merge hdkey, better logic for g1/g2 leading bits

7c0c628

fix compresspoint g2

2755df7

g1/g2 serialization correct

9b6af79

explicit order of ops

b24e49d

temp remove G2 compression check

9e4f492

Merge branch 'master' into ietf

b9c64da

Minor fixes from merge

262c463

clean up code for mypy/flake8 - black

c3cf028

enough to start looking at plotter

9a983a2

Alex Wice and others added 3 commits July 10, 2020 14:53

flake8

9cfc745

lgtm assignment operator

d9fdb93

Merge branch 'ietf' of github.com:Chia-Network/bls-signatures into ietf

b8d2880

add 0x80 compression bit for 0 and 48 byte

3bbedbb

reverted bit changes and commented out G2 tests

2e41ded

wjblanke and others added 3 commits July 10, 2020 12:09

lets try windows

ae17368

switch repos for relic

3553571

Remove Unknown distribution option: 'build_requires' warning

5a1d52d

Move all but Windows to build verbosity 0

11fe38a

mariano54 added 2 commits July 13, 2020 14:26

Changes required for chia-blockchain (deepcopy)

c05c132

Merge branch 'ietf' of github.com:Chia-Network/bls-signatures into ietf

502f981

ADD hd keys tests

a97974c

added gmp include folder to python-bindings cmake

9a4ee51

Alex Wice added 4 commits July 13, 2020 18:08

trying to clean up tests

e89f598

Merge branch 'ietf' of https://github.com/Chia-Network/bls-signatures …

d6bdb65

…into ietf

pythonbindings cleanup comments

f21b2ac

pyecc tests

3570dc2

Move ci's to pytest

781f0b7

Add test vectors ietf

963e618

Alex Wice and others added 4 commits July 14, 2020 18:29

g2 elements start with 0b000 now

929c451

Use FromSeed

11daae1

merge

33df955

Merge branch 'ietf' of https://github.com/Chia-Network/bls-signatures …

a972a3e

…into ietf

mariano54 added 2 commits July 15, 2020 01:49

Revert bad test vectors

e7ad0da

Merge branch 'ietf' of github.com:Chia-Network/bls-signatures into ietf

3c105e6

hoffmang9 approved these changes Jul 14, 2020

View reviewed changes

hoffmang9 merged commit c6010c8 into master Jul 14, 2020

hoffmang9 deleted the ietf branch July 14, 2020 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ietf #119

Ietf #119

mariano54 commented Jun 29, 2020

mariano54 left a comment •

edited

Loading

mariano54 Jul 2, 2020

mariano54 Jul 2, 2020

mariano54 Jul 2, 2020

mariano54 Jul 2, 2020

mariano54 Jul 2, 2020

mariano54 Jul 2, 2020

mariano54 Jul 2, 2020

mariano54 Jul 2, 2020

mariano54 Jul 2, 2020

mariano54 Jul 2, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 12, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 14, 2020

lgtm-com bot commented Jul 14, 2020

lgtm-com bot commented Jul 14, 2020

hoffmang9 left a comment


		static G1Element SkToG1(const PrivateKey &seckey);

		static vector<uint8_t> Sign(

Ietf #119

Ietf #119

Conversation

mariano54 commented Jun 29, 2020

mariano54 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 10, 2020

lgtm-com bot commented Jul 12, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 13, 2020

lgtm-com bot commented Jul 14, 2020

lgtm-com bot commented Jul 14, 2020

lgtm-com bot commented Jul 14, 2020

hoffmang9 left a comment

Choose a reason for hiding this comment

mariano54 left a comment •

edited

Loading