-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No subgroup checks performed in point validation #271
Comments
I just fixed it with |
Thanks @dfaranha This is what blst does: https://github.com/supranational/blst/blob/48f69febca82082298f18e31509670b20f64f2ed/src/map_to_g1.c#L499-L516 Did you also check G2 subgroup checks? |
Yes, my starting point was also Bowe's ePrint, but I replaced the multiplication by (z^2 - 1) with the endomorphism. Too good to be true, I guess. I have the same subgroup check as in blst implemented for G2. |
@hoffmang9 Can you update relic to 3429421e84b3a2124d8744573084c1a0ba0b729a or later? |
I actually need Amine to update his fork first as there is a compilation related upstream issue getting worked out.
…-Gene
On Aug 29, 2021, at 5:40 AM, Guido Vranken ***@***.***> wrote:
@hoffmang9 <https://github.com/hoffmang9> Can you update relic to 3429421e84b3a2124d8744573084c1a0ba0b729a or later?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#271 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHHYNTFROR5LRELQH6V7ID3T7ITFNANCNFSM5CKWUNSQ>.
|
Unfortunately 3429421e84b3a2124d8744573084c1a0ba0b729a introduced the following test failure: https://github.com/Chia-Network/bls-signatures/blob/main/src/test.cpp#L478
|
I don't fully understand what is going on there, but I assume that the group element being tested does not have the right order? |
I am looking into this issue now. |
* Update Relic anchor to aecdcae7956f542fbee2392c1f0feb0a8ac41dc5. Addresses issue #271. * Update tests * Switch relic_ietf_64 to the aecdcae version. * Use our main repo as the related PR got merged. Co-authored-by: Mariano Sorgente <[email protected]>
Fixed in 1.0.6 and released in chia-blockchain 1.2.6 |
…a-Network#277) * Update Relic anchor to aecdcae7956f542fbee2392c1f0feb0a8ac41dc5. Addresses issue Chia-Network#271. * Update tests * Switch relic_ietf_64 to the aecdcae version. * Use our main repo as the related PR got merged. Co-authored-by: Mariano Sorgente <[email protected]>
7f9f8d910 Another try. 77a59d4df Use compiler intrinsics instead. 43820e82e Reverting, did not work. a4c6f4797 Changing approach to lzcnt. 293e12671 Replace regular recoding with GLV-SAC. 7d60a4bb7 Fix memory allocation issues. c3d0c3504 Add tests for GLV-SAC recoding. d7d9b1a5c Small spedup. 2b0fb522a Another attempt to fix. ab4d0149c Potential fix for MacOS. aec2bd459 Remove UB. 9d82cb8a1 Fix bug in memory access. 31eb7eaeb Fix for 32-bit version. a65e5ef12 Added new algorithm for Jacobi symbol. f6df7a2fd Slightly faster Jacobi symbol. 3a2b97c8c One more fix. ae4084d94 Unify with inversion code where delta is negative. 37d180b39 Fix initialization. 6a95b57ec Further speedup. a09e4d51b Reduce details. a7404b5d7 Another fix. 43ad9ef03 Refactor Pornin's algorithm. a8bea1656 Fix! 7cda359d0 Maybe now. fe3191148 Fix. 2de25e5e5 One more. 3892b14e7 Yet another try. 21118fd6a Again. 3ac43b79c Test some more. 01496ba1b Reduce conflicts. b54ea1ebb Reduce conflicts. a1934825c Update prototypes. e66a45add Change MingW Makefiles. 57b01bb57 Fix conflicts 8bb67fa5e Bugfix. 3f39874ae Another attempt to fix GMP. 17c40d11c Minor speedup. 78d06c3fd Adjustment. a0472df64 Remove duplicate code. a4acd468a Adjust types in low-level functions. 514358dab Omit annoying false positives emitted by compiler. d74bceda9 Remove more compiler warnings. 7120faed7 Fix compiler warnings. b0a4baaec Missing prototype. cc73c65ba Remove compiler warnings. 2a3ca52ba Fix LABEL for some curves. b89695c0d Update relic_bn_mul_low.c bf8c7a30f Fix general case when p = 3 mod 4 and FP_QNRES=off. b02e550b0 Fix for BSI_P256. 7b849c119 Support fields where -3 is QNR. bba57ce67 Support fields where -3 is QNR. baf00feb9 Update gmp.yml 1d7349b1c Again... 8cd6344a3 Install more GMP packages. c8925a8b7 Trying again. e9b15bbb6 Merge branch 'main' into pornin 1878a521b Another attempt. 6c8299a3a Testing against MINGW64. cfe0e1579 Update gmp.yml 5e7f6cbe5 Minor fixes. 76ac96016 Make search more flexible. d89a710ce Fix GMP backends. 00bed5b11 Remove unnecessary variable. 9a42dead1 Refactoring of types. 7bcf101d4 Fix variable naming bug. ce1a1b8ae Refactor hashing. c55b5db55 Rename internal function. 9164382e0 Merge pull request Chia-Network#292 from relic-toolkit/pairing192 911ed2af7 Remove redundant code by moving function from FPX to GT. e52d0437f Rename ep_param_embed to ep_curve_embed. 63f24c9dc Add missing preset. 44ebbb9c2 Do not run tests for extensions we do not need. 8bc067fb7 Reduce number of tests/benches to speed this one up. e28bb68b4 Minor polish to remove warnings. 2201eda8c Restoring towering for BN-446. bd42269ba Fix towering for BLS12-446 curve. dc6bce073 Update preset. ac4b411f9 Simplify handling of QNRs. 7d6138c16 Search for GMP harder. 08ddd8702 Save some space with the new APIs. c39487b14 Many documentation fixes and minor API changes. 184bfd733 Change API for general scalar mult to newer one. 856a0970e Refactor API for RHS. 59a448ae6 Generalize exponentiation to more curves. a4b5c6298 More missing benchmarks. 0d1e82d73 Add missing benchmark. 427deda71 Rename function to match new pattern. 7e86e2195 API refacor for constant-time functions. a5c1c9e30 Configuration fix. 1e72f297e Fix GH Actions build. 69d7dc619 Make LWREG use table. eb8d511db Simplify ep_mul_lwreg. 308412eda Fix bug in BN curves. 088185279 Fix for more coords. b5e5a7c4c Another big refactoring to include more coords for ep2. 1ffffb0b6 Fix bugs in conversion to template. 3db85f88c Now refactor point doubling. cf085802a Big refactoring of the EP module. 1d746d722 Update presets. 6f7e8e3c7 Merge pull request Chia-Network#290 from RoboSchmied/RoboSchmied-AGfixT20 9efc9d210 Fix: 1 typo 72daaa74f Fix compilation bug. e8c157265 Remove N16_P765 parameters. 4ccd5c0d9 New hash function. 42143dd01 Fixes to the formulas. a22aec229 Change parameters again. a17e89d37 Add new hash function. 6c97815cd Update checkout action. 554cb0fc8 Fix unbalanced Bezout coefficients (Chia-Network#287). 94c00d9a6 Optimize epx_mul_dig() c2e0af7dd Fix type mistmatch. 16f8a992b Add new parameters. 3c2282e14 Merge pull request Chia-Network#286 from relic-toolkit/kss16 eabc11964 Fix type mistmatch. e80d1e4ad Fixes to bandling beta in EP. d7a31ed65 Better support for extended coordinates in ED module. 66d3a670a Simplify and fix bound problems with symbol. fde494f94 Refactor divstep symbol computation. 35fc0b3d7 Simplify handling of inversion constant. 536ef308b Make divstep inversion more general. 628eb8660 Improve support to fast 25519 backend. ba4a8dee3 Accelerate fexp a bit for BLS24 curves. afbbd0a1f Update relic_fp2_sqr.c 2d7fb208a Revert previous change. 498db5176 More fixes to STRIP. 7c55868e1 Make sure points are in affine coordintes when mixed is used. fd9def92b Fix for bit counting. d3d5d5fdb One more fix to STRIP. 21410435e More fixes to STRIP. bcefb2f6a Fix STRIP. a672d5a8d Fix compilation problem. a7beed7bc Simplify code a bit. 36f22d1b5 Make encoding more constant-time. 36e87950f Remove blank line. 5821f9122 Update relic_ep_param.c 47a2890f8 Update README.md 85f80800e Faster final exponentiation. b5f633562 Added missing benchmarks. 6a01d9a37 Merge pull request Chia-Network#283 from relic-toolkit/fm18 ab3f2f391 Cleanup and membership testing for FM18. 331745e81 More fixes. 174132348 Add pairing over FM18 curves. 8332a0b91 Make residues in Fp3 more flexible. 1b3688758 Merge pull request Chia-Network#280 from relic-toolkit/fm18 18d139617 Improve support to FM18 curves. 18a12ec6c Fix naming issues. 455d97a90 Fix type mismatch. 280e9341b Adding G2 for FM18. 148b3d51b Ugly hack to fix FM16 without breaking others. 32b616994 Restore buffer. e960f00d5 Fixing one last issue. 062f20028 Fixing indexing bug. f756054ec Fixing memory allocation problems. d9e9d771a Added support to G1 for FM18 curves, with some minor refactoring. f46ecf0fb Added FM18 parameters. c5ac648f4 Fix bug for supersingular curves. 6b9054574 Fix params. 8aa5776f7 Fix pointer arith. 321a304b8 Simplify code and remove extra allocations. f088435c8 Fix allocation. 2ad2164b3 Merge pull request Chia-Network#276 from relic-toolkit/fm16 5aa9c1b2a Re-enable fastest family. 33a7ffb4f Speedup in hashing. 60c99de43 Final touches. 03211d99e Final exp for FM16. 4a137af6c Speed up membership testing. ca006bcb6 Speedup cofactor multiplication in E(Fp4). 53d229a48 Fixes. a721cf2b9 Merge branch 'main' into fm16 e5c6d38c6 Update relic_pc_exp.c 4c62e767d Fix for hashing that was not multiplying by cof. e2dec0313 Minor improvement for conditional complation. 1c0056af9 Make pairings handle JACOB better. dd7a569b2 Remove useless code. 22e8f98f4 Fix bug in gt_exp_dig() e293817a8 Remove file not needed. 0c0a86772 Update LABEL due to new API. 22a335747 Big restructuring of the exponentiation functions. 69130d2ad Typo. 3aab269ee Better comment. 92a7f70d7 Handle case when p = u mod n. d16558912 Fix for FM16. 95ff73462 Merge branch 'main' into fm16 f29d27f9d Fix for scalar mult in G2. 29a62e999 Add support to FM16 family. 4259ff290 Fix bug with negative operand. f05130cd6 Update relic_fp2_mul.c 358e66a64 Merge pull request Chia-Network#273 from kassane/cpp-compat d101d684c code: headers C++ compat cmake: Add library alias cmake: get target include (needed to fetchContent) 047d53241 Quick simplification. ce5e12162 Merge pull request Chia-Network#271 from relic-toolkit/kss16 dda4844a8 A (hopefully final) fix. 38ba1f5ea Merge branch 'main' into kss16 38737dad8 Add 511-bit binary field. b6d0c2f3d Fix negation across multiple backends. 1fc483fb4 Fix type promotion bug. d9056dfa0 Swap variables to match paper better. 81f7f83c6 Remove contrib code. 56b378f67 Uniformize symbol impls. 5751f0f07 Slight simplification. 8c196d34e Print parameters that fail. 6a8d66364 Update CMake. 605f5aa69 Minor optizitation for divstep-based symbol. df3d94a0e Add more primes. 015f3fd89 refactor. 3d60e31b8 Minor polish. df8f6c9d4 Remove unused vars. f851108e0 Remove unused variable. 7fe5b2712 Minor refactoring for speed. 9548d266c Update arch.cmake b850a9a28 Fix param setting. 060c00c05 Typo again. 74dcd9c7b Fix typo. 72c5f2eef Adding CTIDH prime fot a quick test. 77f0086c0 Indentation. 308f100d2 Refactor WSIZE configuration. 0fd578b7c Fix compilation error with different config. b3097b46a Remove repeated comment. 9e0d3ceb4 Benchmark conditionally. f25924fbf Update presets. 80cbbfc7d Fix memory error. 965e493f3 Faster handling of cofactors in BLS48. 614a4e699 Restoring lost cofactor multiplication function. 95fe87017 Update presets. 8109e7c8c Reverting. 85d6e9750 Faster attempt. aa271f6de Remove ternary operators to reduce chance of compiler interference. 91e2d86db Pick faster algorithms for BLS12-381. ed7a87739 Add optimized code for BLS12-381 from CryptOpt. 37d774fc9 Make it compile with clang. c582f852c Additional fixes to KSS16-330. 4163bbecd Fix the other case for KSS16. 010b656a0 Make K16-P330 visible to PC module. ff891a3e8 Adding KSS16-330 curve. 707fdcc1a Fix to GMT8 curve. a777c5661 Fix configuration bug. 0cc973d21 Trying again. 95571b24b Fallback to fp16_exp_dig when exponent is too small. d1dec5227 Typo. cb16c42bb More benchmarks. fd9cbae9c Adding more benchmarks. 0f97655e5 Adding missing benchmarks. 4181a52ce Fix in conditional compilation. c2143d0b9 More hashing. 9825beda3 Further refactoring. 67ef51966 Refactor hashing to curves with a = 0. 5d6089071 Enable faster hashing for more curves. b769beb67 Uncomment tests. 564a6752e New hash function for E(Fp4). c78bdd370 Make Koshelev hashing constant time. 4ffee2421 Remove artifact. 0e03f0e56 Implement Koshelev hash function. bbb9b9ed2 Fix cases when there's no cubic extension. 6f40e4dae Fix final expo. cb7f5f21c Fix Frobenius in Fp4. e83d6da2d Fix generation of GT elements. 975fb3913 Faster GT subgroup testing in new curve. a193b67b7 A bit more code. 48d96372e New curve over 765-bit field. 7aa025684 Added new family with k = 16. 18ecf8c1e Optimize G_T membership testing. 1bf5e3455 Optimize KSS16 case. aff224497 Update formulas and fix docs. 1d089054d More code for KSS16. 3a5a03995 More KSS16 code. 8fe8fc2d6 Fixes to E(Fp4) 8751059d9 Fixes. 554092692 Fixes to Fp16. a13ada000 Add 12-lib ASM code for x64. 0ad7eaaa2 Fix k=1 projective. 8376c2ae5 Code for Fp16. 6f467100a Add new curve over Fp4. be9e9a6b1 Add KSS16 curves. 4de8c7303 Bug fixes. 55e16a75a Faster/better code for k=1. 0181f8544 Build ep_psi unconditionally. 217b2010b Update LABEL. c328e74e0 Include prototypes for pairings in k=1 case. 7fbbf53aa Fix previous commit. 0ffc2360a Initial support to curves with k=1. 3fc9980bd Typo b406fe963 Fix cofactor. 0e6cc3682 One more fix. a58203c97 Add new curve and generalize E(Fp2) a bit. b466bba29 Added helper macro for when moving between G1 and G2 elements. cbcb7ffb0 Extend QR fixes to extension field. e66864336 Fix corner cases for residuosity. da6e3ac68 Improvements to square root extraction. ddd1984a7 Update README.md a3ba0b3c4 Faster cofactors for SG18. 126fbc63e Fixes for SG18. 3105d66e9 A few more 4eb38d42c Initialize vars. c24046aa2 Restore K18_P508 and make KSS18 code a bit more general. 1c935ec68 Simplify testing code. 2a76750ce Rename KSS -> K18 and fix a corner case. a5215dee2 Fix parameter selection. a615b2cfc Improve curve setting logic. b8a6a7950 One last fix. a126bc538 Fix support to SG18 curves. e8b5fd9c7 Adjust cofactor multiplication. 8223c28b3 Membership testing in G1 for SG18. ce713a3cb Membership testing for SG18. 417d9e9ea Fixes for SG18. 0ae9c6e3d Better testing for square roots. 26951bf60 Fixes for higher-security curves. d60460fee Make BLS48 a first class citizen. b21b9bbc1 Fixes to Montgomery ladder, remore redundancy from beta computation. 273d00539 Many fixes. ad04d95a7 Port memory dealloc fix to other implementations. 352617d43 Fix memory dealloc. e5ab54067 Fix corner case in fp3_srt() and remove warning in fp3_mul_frb(). 019930162 Remove printing. 48554f42d Fix memory dealloc. 5bd2b8b7b Refactor hashing to make it constant time. 7129b928f Indentation. f10b16631 Free memory. 14d8f9488 Fix memoery safety violations. 9dd46624b Implement criterias for generating hashing constants. fa686969b Add missing functions to LABEL. c38dc758a Adjustments to restore correctness. c1f88b81f Fix conditional compilation issue. 04ab0e54d Remove compiler warning. 82e3e6cf0 Revert previous change and make test more flexible. b8acda26d Fix problems with STRIP=on. bfe8b78ad Merge branch 'main' into symbol-asm 697ac1918 Fix compile issue. d8df1980a Simplified EP configuration. 9caf2a60b Make towering more strict for random primes. 06f162f47 Fix test case for GLV recoding. 3dd1aff6e Generalize hashing to all curves with a = 0. e9039ae39 Support more flexible towerings above Fp^3. 2c54b5b85 Initialize variable. 35a40e99d Fix corner case. d72db1f69 Implement cube root modulo p. f929adcb0 Fix conditional compilation. 46d42b0e8 Prime prime to make it clear what field is being used. 58e126455 Fix conditional compilation issues. 7fb993f92 Adding missing API for extension field arithmetic. 0f364d144 Slight speedup when multiplying by 4. aaf5bec56 Formatting. ca59eba3a Merge pull request Chia-Network#218 from relic-toolkit/hacl 7a1a7115d Fix for conditional compilation. c5aa4e1ae Add real lazy-reduced implementations. 26b45db26 Reduce code size. f8913951d Better support to BLS48. 9188e41a9 Restore code removed by mistake. 349bd20ed Make BLS48 an option for pairing-based protocols. 7cc494a32 Make BLS48 an option for pairing-based protocols as well. d1707b785 Minor improvements. 6948b6f8d Formatting. 49a0236b6 Faster cofactor multiplication. 1713ef3f7 Reduce memory, improve comments. 140de7f6d Polish cofactor functions. 3f5fcc53d Fix LABEL. 0bb12c0c8 Merge branch 'main' into symbol-asm 1c5a18171 Merge branch 'main' into hacl 503c391bc Minor tweaks. 9c936cf8e Merge pull request Chia-Network#266 from eccdaiy39/main 97b1962a3 Better testing of corner cases in multi-pairing. 9f8e8de9d Fix LABEL to respect MULTI config. 24c7ba6eb Add Ep3 to LABEL. 7a4df27b1 Merge pull request Chia-Network#265 from tylerliu/main 18de96b29 A bit faster by exploiting subfield operations. e27f16195 Faster again! 9a839f576 Improve square root in Fp3. 1dcac4ac6 Improve square root in Fp^3. 763daea58 Implement missing case for square root in Fp^3. 00cde26c7 Minor fixes. 5fa160dfb Refactor square root extraction when p = 1 mod 4. 54b699cb2 updating the method for G2 and GT membership testings in the BN family 6c383a1e9 Fix Linking of multiple builds with MULTI on f8c2dee1d Fix. 7d885d1ba Other fixes to restore KSS18 curves as the default. 44fa77621 Catch the corner case of unity. 48ff1d82f Restore K18 as the default. 4e87ddc06 Formatting. 41c8f80c4 Oops, missed this change in previous commit. f2425c5b5 Merge pull request Chia-Network#262 from jgdumas/GPF 70dc2089d Minor adjustments to remove compiler warnings. 2ee1ca6d8 Faster endomorphism for E(Fp^3) 1c8b04f2e Instead of hoping for the correct number of bits, fix the largest bit bdd158656 Faster Tonelli-Shanks. bf1056ea9 Off-by-one error. 813283640 Make BASIC multiplication more flexible. e5a7c0522 Remove redundant checks. dc5f70ce0 Adding SG18 params. 44f2defcb Simplify code in several places due to modular reduction. 76ca8f89a Merge branch 'main' into symbol-asm 6f343c899 Add new function to GMP backend. 19e5ec54a Add 127-bit prime for benchmarking. 0deb9f7d4 Minor fixes to compiler warnings. 04154faa3 Refactoring of pairing-friendly curve parameters. 4c974af05 Update script. f7c9bffda Update LABEL. 5da54617f Extend implementation of E(Fp8). 9a6cdafce Fixes for E(Fp4). b17d513f0 Implemented square root in Fp8. 6fb32172d Make square root extraction. b9ac13272 Do not break protocols. f3be9ba88 Save memory now. b6c4d73c0 Optimize hashing to G1 for KSS18. a3bff6335 Update README.md 22a1ecb15 Allow benchmarking of this function, as this is newly implemented. ecea4d8f8 Faster square roots. 459b00184 Do not use advanced scalar mult algorithms here. 8aef0e82d Fix tests. 4d279622c Benchmark cofactor mult. 14d0297c1 Add benchmarks for E(Fp3) and cofactor mult. c1e9eba15 Avoid running tests for the same curve again. abe670406 Prototypes, tests and benchmarks for the new functions. 70887dfdb Code refactor. 392ce17c8 Refactor to include SWIFT. 0472a08b9 Fix bug in sign handling. 75ac3e493 Silly bug b06b72d53 Align API with rest of library. 06114a5cb Merge branch 'main' into symbol-asm 3e107d3aa More accurate testing. 269600f40 Improve sign handling. 9d261bfb3 Better hashing to E(Fp4). d25be8512 Reverted problematic casts. 24abff94e Minor adjustments for portability. 4876cbae5 Add explicit casts. a9efa5567 Remove unused variable. 392b6ac97 Update LABEL. 901ac84ff Fix problem with test. d3ff94934 Reduce dbl_t usage. ab6ec6965 Restore mistaken cleanup. 788c5f667 Use more ASM. 66e26eb23 Add missing test. 3e3b7fba7 Remove redundant code. 577cbc9d5 Make code more portable. 94088b52e Restore code from BLST. a2ff48e61 Handle lazy reduction in a cleaner way. dc9f502c9 Handle exceptions correctly. c759b6cb3 Add missing reference. 0e8c69de1 Generalize QR tests to low-degree extensions. ca63ecf05 API and code cleanup. 26b8f13c0 Fix. 06ae03873 More type issues to fix. 77a90a688 Fix type issues. 3d502ff49 Update LABEL support with new API. 86c30d131 Minor adjustments after merge. ef862c78a Merge pull request Chia-Network#259 from relic-toolkit/kss18 6d832853a Merge branch 'main' into kss18 19baaf04b Fix affine case. ca4a085bb Improve KSS18 pairing. d4cf7f6fa Fix regression. b369a6740 Type issue. e6d6f6e90 Simplify code and avoid non-initialized data. 4d57a0440 Fix more type issues. 1d8df4207 Fix regression. 9b5a2af0f Faster subgroup membership tests. 9bc9c872e Accelerate cofactor mult. 9e8d03416 Subgroup membership testing for KSS18 curves. 78bf305d2 Fix type issue. f6e3c13ce Fix type issues. 1b0315ef7 Minor polish and simplification. 5404c676c Bugfix. 9d1f30bb5 Simplify code. 800288e5b Reduce number of variables. 7c721a37c Unify WIDTH/DEPTH configuration variables, refactor simultaneous modular exponentiation. b2c55b8c0 Merge pull request Chia-Network#227 from jgdumas/bnMXPsim 3f1b7f4e4 Merge branch 'relic-toolkit:main' into bnMXPsim 829fe1b32 Refactor MD module. 6dd088c16 Address buffer overflow. c7fb6055c Merge branch 'symbol' into symbol-asm 9ffd1394b Optimization. 3b6326fc7 Bug fix after API change. 4fa5b176d Trying again. ae049e633 Fix dep. cfa740ae0 Minor polish. 7db351248 Merge pull request Chia-Network#258 from DavidKorczynski/cifuzz-int e72db4813 Add CIFuzz Github action. 1df3c57b3 Remove curves with wrong embedding degree. d14438870 Add preset for KSS18 curve. f10cb4c4b Remove printing. ecb5ad9a8 Fix several issues. 8f763e258 Remove unreachable code. d320bfa74 Notation. 11e58d3f8 Remove useless condition. 9c5dfd432 Remove FIXME. f9b13f49d Rename variable. 77a4bd94e Rename variable. c1c567ce7 Initialize error variables. 361a77db5 Use shorter uint_t instead of unsigned int. 24d4d6d78 Remove CodeQL warnings. 02a3a6a59 Remove print. 6e78dfcec Merge branch 'master' into kss18 5e360ab73 Merge branch 'main' into bnMXPsim d3d9dafda One more fix for the int -> size_t refactoring. af23d574b Sync RAND interface with rest of library. 34580d840 Huge commit improving the API to use size_t instead of int. 0ba57234a Use size_t instead of int in the API. 421f2e91c Remove dangerous API for returning small primes from an internal table. 2c93259f3 Merge pull request Chia-Network#256 from lgtm-migrator/codeql ac4e96dfd Update README.md eb6d7e600 Add CodeQL workflow for GitHub code scanning 05feb20da Merge pull request Chia-Network#254 from relic-toolkit/addSupportForChinaSM af94e798e Fix multi-pairing computation. fce101bf0 Do not run pairings when binary or Edwards curves are selected. f9f95c09a Fix memory issue. a119db8b2 add support for SM2 curve (Chinese SM2 standard) 4ccd21510 modify the finalExp for SM9 curve so that the pairing result is consistent with the example of SM9 standard 75d5e01cf Add pairing code. 699d22c3e Fill more of the API. bb71c26bf Added pairing for KSS18. f9cda1f3e Improved arithmetic over the twist. b300acb5b Better towering. d6f3715a8 Simple fix to swap the whole coordinates. b9cd1a171 Benchmark new hash function. 36be328f0 Merge branch 'main' into bnMXPsim 50189329d Another refactoring of hash to curve. 24dfa0b36 Cleanup. d3a1f9476 Update relic_ep3_mul_sim.c a8a8cc28a One last fix for ED module. 0daffb5ad Fix current breakage. dd9ac2d75 Fix bug with passing arguments. 173f5fd21 Simplify config. c9c4bd525 Update config elsewhere. 339d3db93 Update default config. 9d585fb4e Refactor hash to curves. 29373fd0b Use symbol computation to accelerate fp2_srt(). bdbc743e5 Here comes the large E(Fp^3) patch. 643a60948 Adding E(Fp^3) and KSS18 curves to the library. 3aa036436 Merge branch 'main' into bnMXPsim 0e06ab17c free only the allocated 0adf38440 Merge branch 'main' into bnMXPsim 74e4dae73 slightly better for BN_XPWDT+1 simultaneous exponentiations 51a8944f5 Merge branch 'bnMXPsim' of github.com:jgdumas/relic into bnMXPsim 6accd89ac smoothing times (and testing) small exponentiation cases 120e8cfe3 smooting times (and testing) small exponentiation cases ef31cd87a Merge branch 'relic-toolkit:main' into bnMXPsim cbcc1577c Merge branch 'relic-toolkit:main' into bnMXPsim 6d5cb0aca Now remaining (n-endblockingloop) exponentiations are also simultaneous da7cfcfd6 Merge branch 'main' into bnMXPsim 2f467a8bb Merge branch 'main' into bnMXPsim ab7d6c968 Merge branch 'main' into bnMXPsim 9736c625f Merge branch 'main' into bnMXPsim 8d9e123c0 Merge branch 'main' into bnMXPsim b8f4598b0 Merge branch 'main' into bnMXPsim 0d7b614d7 uniform util_print for mxp_sim e8ec4b817 also define instead of const int 5d0e85b60 define instead of const int aa7fbbd8e separate tables bb0c41757 no need 64bits, specially for casts 5d55889ec more comments 25118e37e noexec c9cc15750 Implementation of generalized Shamir trick (BN_XPDWT simultaneously) for R = \prod p_i^{u_i} \mod m b8857a48a Revert unrolling. ac76f4b3e Minor polishing. 0b0fd7632 Unroll here too. d8d903b80 Extend ASM experiment. c2789b19e Better formatting. 6e00c02d7 Unroll inner loop. 9164bcefa Adjust interfaces. 8db9e9e98 Final renames. 808f92b68 Extend ASM experiment to inversion. 65f306c8a ASM experiment. 9e0a53ce5 Compiler inlines anyway, no need for explicit. a9d152e58 Unify with symbol computation. 7def2400c Removing last occurrences of dbl_t for portability. 6e98943e5 Polishing. 9c7c02ca6 More simplify. ae713c480 simplify f64646c99 faster cneg a58b06ad8 Portability. e7d142699 inlining a36517264 inlining c7d23d14c Another test. 3dd2122c3 Minor speedup. 42655a5ac Do some ASM accel experiments. 059f03e7d Yet another fix. 95d388cc6 Make estimates for SMLERS more accurate. 71b1169e6 Update output to be more readable and precise. dd32ea9d2 More careful verification of ERS/SMLERS. 169bc5675 Optimize ETRS further by reducing number of inversions. 5c493c012 Minor speedups for ED module. b769348cc Fix typo. 668512e5b Integrate HACL into RELIC by adding backend and tolerating lazy red. 5416123be Better conditional compilation. git-subtree-dir: depends/relic git-subtree-split: 7f9f8d9109e72e7256062fc516324e611839f937
The following G1 point:
Is on the curve but not in the subgroup. G1Element::CheckValid only performs a curve check but not a subgroup check. Is this intentional?
@dfaranha
The text was updated successfully, but these errors were encountered: