Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

ITX transactor provider #204

Merged
MakMuftic merged 38 commits into from
Jan 14, 2022
Merged

ITX transactor provider #204

MakMuftic merged 38 commits into from
Jan 14, 2022

Conversation

@mpetrun5
Copy link
Member

@mpetrun5 mpetrun5 commented Dec 3, 2021 •
edited
Loading

  • moves sign and send transactor to separate package to allow for more transactors
  • add itx transactor with gsn forwarder implmementation
  • allow for store to be more generic and separate it into blockstore and noncestore

Related Issue Or Context

Closes: #68

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

Matija Petrunic added 25 commits December 2, 2021 17:46
Implement itx transactor
bec132b
Fix invalid itx response decoding
ca14b87
Add gsn forwarder implementation for itx
b0b9032
Fix gas required for forwarder be too low
aceb9b0
Add itx tests
3e3b6ca
Add default itx transactor opts
e9f8e82
Make itx tests more predictable
75f6490
Add gsn forwarder tests
96494ed
Remove print
00c5974
Change default itx priority to slow
c7b2d72
Fix gas limit being increased before getting forwarder data
7c6a20a
Fix evm client using variadic arguments as an array
467bc8d
Fix itx tests
65f0634
Split blockstore into NonceStore and BlockStore
73a6fc9
Refactor block storage to accept BlockStore struct instead of generic…
1f067e9 
… writer
Fetch gsn nonce from storage and contract on startup
38d3d29
Add store tests
df14e6b
Merge branch 'main' into mpetrun5/itx-provider
bca310c
Separate sign and send and itx and move gsn to itx package
ec87eea
Fix pack when gas limit is not bit.Int
8da77e2
Change sign and send transactor import
a4f5262
Change how gsn handles nonces
2a676e1
Update forwader contract to match new contract format
b5a4a50
Update itx tests
36b455c
Update go.mod
913c268
@github-actions
Copy link

github-actions bot commented Dec 14, 2021

Go Test coverage is 49.0 %\ ✨ ✨ ✨

@github-actions
Copy link

github-actions bot commented Dec 15, 2021

Go Test coverage is 48.7 %\ ✨ ✨ ✨

@mpetrun5 mpetrun5 marked this pull request as ready for review December 17, 2021 10:39
@mpetrun5 mpetrun5 requested a review from vezenovm as a code owner December 17, 2021 10:39
@mpetrun5
Copy link
Member Author

mpetrun5 commented Dec 17, 2021

Successfully tested with new contracts.

@github-actions
Copy link

github-actions bot commented Dec 17, 2021

Go Test coverage is 48.8 %\ ✨ ✨ ✨

MakMuftic
MakMuftic suggested changes Jan 11, 2022
View reviewed changes
vezenovm
vezenovm approved these changes Jan 11, 2022
View reviewed changes
Copy link
Contributor

@vezenovm vezenovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just Mak's couple comments. Also, in the original PR (ChainSafe/ChainBridge#653) there is an implementation of a Gnosis Forwarder which could be very useful for relayers. For now that seems out of scope though and is something that can be discussed and added in a separate PR.

tcar121293
tcar121293 reviewed Jan 14, 2022
View reviewed changes
tcar121293
tcar121293 reviewed Jan 14, 2022
View reviewed changes
tcar121293
tcar121293 reviewed Jan 14, 2022
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 14, 2022

Go Test coverage is 49.2 %\ ✨ ✨ ✨

@github-actions
Copy link

github-actions bot commented Jan 14, 2022

Go Test coverage is 53.4 %\ ✨ ✨ ✨

@MakMuftic MakMuftic merged commit d284552 into main Jan 14, 2022
@MakMuftic MakMuftic deleted the mpetrun5/itx-provider branch January 14, 2022 13:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@P1sar P1sar Awaiting requested review from P1sar

@nmlinaric nmlinaric Awaiting requested review from nmlinaric

@roethke roethke Awaiting requested review from roethke

3 more reviewers

@tcar121293 tcar121293 tcar121293 approved these changes

@MakMuftic MakMuftic MakMuftic approved these changes

@vezenovm vezenovm vezenovm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ITX provider as transactions sender

5 participants

@mpetrun5 @tcar121293 @MakMuftic @vezenovm