This repository was archived by the owner on May 9, 2024. It is now read-only.
Merge relayer chain configs #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrun5
requested review from
MakMuftic,
P1sar,
nmlinaric,
roethke and
tcar121293
|
Go Test coverage is 33.9 %\ ✨ ✨ ✨ |
1 similar comment
|
Go Test coverage is 33.9 %\ ✨ ✨ ✨ |
P1sar
suggested changes
Nov 24, 2021
Contributor
P1sar
left a comment
P1sar
left a comment
There was a problem hiding this comment.
Also could you please make corresponding changes to celo-module and example app in cooperation with @nmlinaric
added 18 commits
November 24, 2021 12:21
mpetrun5
force-pushed
the
mpetrun5/merge-relayer-chain-configs
branch
from
4487f7b to
e3eca29
Compare
|
Go Test coverage is 33.3 %\ ✨ ✨ ✨ |
1 similar comment
|
Go Test coverage is 33.3 %\ ✨ ✨ ✨ |
P1sar
reviewed
Nov 25, 2021
MakMuftic
approved these changes
Nov 25, 2021
|
Go Test coverage is 33.9 %\ ✨ ✨ ✨ |
P1sar
approved these changes
Nov 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged relayer and chain configs into single ChainBridge config file
Description
Related Issue Or Context
Closes: #161
How Has This Been Tested? Testing details.
Types of changes
Checklist: