Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(wren-ai-service): enhance prompt for localization language #952

Merged
merged 1 commit into from
Nov 25, 2024
Merged

chore(wren-ai-service): enhance prompt for localization language #952

merged 1 commit into from
Nov 25, 2024

Conversation

paopa
Copy link
Member

@paopa paopa commented Nov 25, 2024

This PR modifies the prompt template to explicitly handle localization for relationship names and reasons in the recommendation pipeline.

@paopa paopa added module/ai-service ai-service related ci/ai-service ai-service related labels Nov 25, 2024
@paopa paopa marked this pull request as ready for review November 25, 2024 09:55
@paopa paopa requested a review from cyyeh November 25, 2024 09:55
cyyeh
cyyeh approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@cyyeh cyyeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyyeh cyyeh merged commit 59b2acf into main Nov 25, 2024
10 checks passed
@cyyeh cyyeh deleted the chore/enhance-prompt-for-localization-language branch November 25, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyyeh cyyeh cyyeh approved these changes

Assignees
No one assigned
Labels
ci/ai-service ai-service related module/ai-service ai-service related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paopa @cyyeh