Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Implementation of vectors raises an exception in
__mul__when you try to operate on a non-vector type.This can be quite annoying, because even if for example
Quaternionimplements__rmul__it will never be called when the vector is on the left side of the equation and instead error out.Furthermore: https://docs.python.org/3/reference/datamodel.html#emulating-numeric-types specifies that (some) operators should return
NotImplemented.Both the python and cython implementations have been tested (existing physics project that makes heavy use of vectors didn't break)