Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

Select component fixes #241

Merged
merged 4 commits into from
Dec 10, 2018
Merged

Select component fixes #241

merged 4 commits into from
Dec 10, 2018

Conversation

zacklitzsinger
Copy link
Contributor

PR Checklist

Check these before submitting your pull request:

  • Visual and behavioral components are separated
  • Exported components are documented with examples
  • Props have JSDoc comments
  • All relevant visual sub-components can be overridden via props
  • Any extra props are spread into the outermost rendered element

Changes to Existing Components

  • Fixed state of select component when disabled (unclickable, proper arrow disabled color)
  • Fixed styling of non-searchable version of select component (no cursor, acts like a button)
  • Fixed an issue where the select component would not open if the input was already selected
  • Fixed an issue where the cursor would magically move to the end of the input (see this issue)

@zacklitzsinger zacklitzsinger merged commit 75e92d8 into master Dec 10, 2018
@zacklitzsinger zacklitzsinger deleted the select-fixes2 branch December 10, 2018 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants