Skip to content

Ensure that mac runs on py311+ #38491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Ensure that mac runs on py311+ #38491

merged 2 commits into from
Nov 13, 2024

Conversation

scbedd
Copy link
Member

@scbedd scbedd commented Nov 12, 2024

Just manipulating our matrices so that mac agents only get py311+.

This is some confusion around actions/runner-images#10812

I don't believe that we'll actually lose access to the python versions, but we were also seeing some failures re openssl configuration for those python versions as well. We don't actually care if mac is on earlier or newer python, so lets just avoid having build issues in the future by adjusting the distribution.

Internal discussion thread

@scbedd scbedd self-assigned this Nov 12, 2024
@github-actions github-actions bot added the Storage Storage Service (Queues, Blobs, Files) label Nov 12, 2024
@scbedd
Copy link
Member Author

scbedd commented Nov 12, 2024

/azp run python - storage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member Author

scbedd commented Nov 12, 2024

/azp run python - ml

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@scbedd
Copy link
Member Author

scbedd commented Nov 13, 2024

The analyze failures are due to conflicts with black. I am working on another PR that will resolve those. (It's due to python - pullrequest not inheriting the args for formatting validation)

Other than that, the internal storage and ml builds are both running clean with no custom matrix and only the filters at ci.yml level. Thanks for the suggestion @weshaggard

@scbedd
Copy link
Member Author

scbedd commented Nov 13, 2024

/check-enforcer override

@scbedd scbedd merged commit 0245b63 into Azure:main Nov 13, 2024
65 of 67 checks passed
@scbedd scbedd mentioned this pull request Nov 19, 2024
l0lawrence pushed a commit to l0lawrence/azure-sdk-for-python that referenced this pull request Feb 19, 2025
* ensure that mac runs on py311+ by shifting it to a deliberate include for py311
* rework to instead use MatrixFilters in ml/ci.yml and storage/ci.yml instead of fully new matrices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
Development

Successfully merging this pull request may close these issues.

5 participants