[RedisEnterprise] SDK validation for TypeSpec #54448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
HarveyLink
requested review from
ArcturusZhang and
ArthurMa1978
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR validates the TypeSpec changes for the RedisEnterprise SDK by regenerating the SDK code for a new preview API version (2025-08-01-preview). The changes primarily involve updating API version references, adding support for a new Migration resource, introducing maintenance window configuration, and updating example file paths to reference the new preview API version.
- Updates API version from
2025-07-01to2025-08-01-previewacross all generated files - Introduces new
RedisEnterpriseMigrationresource with Get, CreateOrUpdate, and Cancel operations - Adds maintenance window configuration support to cluster resources
- Updates sample/test files to reference the new preview API version examples
- Adds
groupIdsproperty to private endpoint connection data model
Reviewed changes
Copilot reviewed 3 out of 75 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Sample_SubscriptionResourceExtensions.cs | Updates example paths from stable to preview API version |
| Sample_RedisEnterprisePrivateEndpointConnectionResource.cs | Updates example paths to preview version |
| Sample_RedisEnterprisePrivateEndpointConnectionCollection.cs | Updates example paths to preview version |
| Sample_RedisEnterpriseMigrationResource.cs | New sample file for migration resource operations |
| Sample_RedisEnterpriseDatabaseResource.cs | Updates example paths and reorders method samples |
| Sample_RedisEnterpriseDatabaseCollection.cs | Updates example paths to preview version |
| Sample_RedisEnterpriseClusterResource.cs | Adds System.Xml import and maintenance window samples |
| Sample_RedisEnterpriseClusterCollection.cs | Adds System.Xml import and maintenance window samples |
| Sample_AccessPolicyAssignmentResource.cs | Updates example paths to preview version |
| Sample_AccessPolicyAssignmentCollection.cs | Updates example paths to preview version |
| autorest.md | Updates spec reference, adds new rename mappings, and format directives |
| RedisEnterpriseRestOperations.cs | Updates API version and reorders methods |
| PrivateLinkResourcesRestOperations.cs | Updates API version and adds pagination support |
| PrivateEndpointConnectionsRestOperations.cs | Updates API version and adds pagination support |
| OperationsStatusRestOperations.cs | Updates API version and documentation |
| MigrationRestOperations.cs | New REST operations file for migration resource |
| DatabasesRestOperations.cs | Updates API version and reorders operation methods |
| AccessPolicyAssignmentRestOperations.cs | Updates API version and reorders methods |
| RedisEnterprisePrivateEndpointConnectionResource.cs | Updates default API version references |
| RedisEnterprisePrivateEndpointConnectionData.cs | Adds groupIds property to the model |
| RedisEnterprisePrivateEndpointConnectionData.Serialization.cs | Adds serialization for groupIds property |
| RedisEnterprisePrivateEndpointConnectionCollection.cs | Adds pagination support and updates API version |
| RedisEnterpriseMigrationResource.cs | New resource class for migration operations |
| RedisEnterpriseMigrationResource.Serialization.cs | Serialization support for migration resource |
| RedisEnterpriseMigrationData.cs | Data model for migration resource |
| RedisEnterpriseMigrationData.Serialization.cs | Serialization implementation for migration data |
| RedisEnterpriseDatabaseCollection.cs | Updates default API version |
| RedisEnterpriseClusterResource.cs | Adds migration resource accessor and pagination support |
| RedisEnterpriseClusterData.cs | Adds maintenance configuration property |
| UnknownMigrationProperties.cs | New unknown type handler for migration properties |
sdk/redisenterprise/Azure.ResourceManager.RedisEnterprise/src/autorest.md
Outdated
Show resolved
Hide resolved
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.RedisEnterprise.Models.ImportRedisEnterpriseDatabaseContent>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] | ||
| public readonly partial struct MaintenanceDayOfWeek : System.IEquatable<Azure.ResourceManager.RedisEnterprise.Models.MaintenanceDayOfWeek> |
Member
There was a problem hiding this comment.
I think we need to make this more specific to this RP to avoid collision.
Member
Author
There was a problem hiding this comment.
Renamed to ClusterCustomMaintenanceDayOfWeek
| public static bool operator !=(Azure.ResourceManager.RedisEnterprise.Models.MaintenanceDayOfWeek left, Azure.ResourceManager.RedisEnterprise.Models.MaintenanceDayOfWeek right) { throw null; } | ||
| public override string ToString() { throw null; } | ||
| } | ||
| public partial class MaintenanceWindow : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.RedisEnterprise.Models.MaintenanceWindow>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.RedisEnterprise.Models.MaintenanceWindow> |
Member
Author
There was a problem hiding this comment.
Renamed to ClusterCustomMaintenanceWindow
| string System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.RedisEnterprise.Models.MaintenanceWindow>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.RedisEnterprise.Models.MaintenanceWindow>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| public partial class MaintenanceWindowSchedule : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.RedisEnterprise.Models.MaintenanceWindowSchedule>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.RedisEnterprise.Models.MaintenanceWindowSchedule> |
Member
Author
There was a problem hiding this comment.
Renamed to ClusterCustomMaintenanceWindowSchedule
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.RedisEnterprise.Models.MaintenanceWindowSchedule>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] | ||
| public readonly partial struct MaintenanceWindowType : System.IEquatable<Azure.ResourceManager.RedisEnterprise.Models.MaintenanceWindowType> |
Member
Author
There was a problem hiding this comment.
Renamed to ClusterCustomMaintenanceWindowType
| public static bool operator !=(Azure.ResourceManager.RedisEnterprise.Models.MaintenanceWindowType left, Azure.ResourceManager.RedisEnterprise.Models.MaintenanceWindowType right) { throw null; } | ||
| public override string ToString() { throw null; } | ||
| } | ||
| public abstract partial class MigrationProperties : System.ClientModel.Primitives.IJsonModel<Azure.ResourceManager.RedisEnterprise.Models.MigrationProperties>, System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.RedisEnterprise.Models.MigrationProperties> |
Member
There was a problem hiding this comment.
this should follow the same naming pattern for Migration model
Member
Author
There was a problem hiding this comment.
Renamed to RedisEnterpriseMigrationProperties
| System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.ResourceManager.RedisEnterprise.Models.MigrationProperties>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; } | ||
| } | ||
| [System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)] | ||
| public readonly partial struct MigrationProvisioningState : System.IEquatable<Azure.ResourceManager.RedisEnterprise.Models.MigrationProvisioningState> |
Member
Author
There was a problem hiding this comment.
Renamed to RedisEnterpriseMigrationProvisioningState
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSP PR: Azure/azure-rest-api-specs#38436
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.