Add organiser logo to confirmation emails #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Receiving emails with the Attendize logo can be confusing for attendees.
|
Thanks for contributing this @egaudrain! I will merge and test the other email templates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Receiving emails with the Attendize logo can be confusing for attendees.
The email Layout file resources/views/Emails/Layouts/Master.blade.php makes reference to
$email_logobut falls back toassets/images/logo-dark.pngif it is not defined.This pull request adds the
email_logoproperty to the objects passed to the view engine.Note 1: The master layout uses
isset($email_logo). I am not sure what happens if the organiser did not define any logo.Note 2: I tested SendOrderAttendeeTicketMail.php and SendOrderConfirmationMail.php, but not the three others.