Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debian package files #927

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

silentjet
Copy link

No description provided.

@silentjet silentjet force-pushed the add_debian_package_files branch 2 times, most recently from 2fe7dc8 to ceae627 Compare March 9, 2024 14:41
debian/control Outdated
python3-setuptools (>= 0.6.29),
python3-numpy,
python3-pytest,
X-Python-Version: all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with this tag set, but this one doesn't look right....

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

debian/control Outdated
libxml2-dev, libxslt1-dev, zlib1g-dev,
python3-setuptools (>= 0.6.29),
python3-numpy,
python3-pytest,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we have a hard dep for this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fixed

Multi-Arch: same
Depends: ${python3:Depends}, ${shlibs:Depends}, ${misc:Depends}, python3-future, python3-lxml
Provides: ${python3:Provides}
Description: Pymavlink is a Python implementation of the MAVLink protocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It really is three distinct things.

The most commonly used mavlink bindings generator. Which also generates the Python mavlink bindings.

A set of utilities that make working with the Python bindings easier, most notably an object to handle opening data streams.

The command-line utilities that you've mentioned.

I don't think you really need to fix this in your stuff here - it's no different to many other places....

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh well, I just have to specify something here, thus stating what I can at my best :D
I would appreciate a more accurate Summary and Longer description.

@@ -0,0 +1,5 @@
pymavlink (2.4.41) UNRELEASED; urgency=medium
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the changelog for the package or the packaged software?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi,
this is a changelog for the package itself... In most cases should be aligned with the actual software version

@silentjet
Copy link
Author

Hi @peterbarker
Thanks for your review. Was busy for quite some time. I'll update it and will upload a clean version. This one is quite made-on-knees, thus dirty (and that's why WIP is here).

@silentjet
Copy link
Author

Hi @peterbarker
Sorry for such a delay, I worked through the actual build and runtime dependencies, and now they are real and validated.
please review.
building the package can be performed using a command:

dpkg-buildpackage -b -us -uc

resulting debian package can be installed using dpkg tool:

dpkg -i ../python3-pymavlink_2.4.41_amd64.deb

@silentjet silentjet changed the title WIP: Add debian package files Add debian package files Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants