Update linear progressbars to new material design #7568
Conversation
|
Is there a way to disable the end stop indicators? I see Google added them on purpose to improve accessibility. However, I don't really understand how this improves accessibility. To me, it looks more like something is broken 🤔 |
|
Yes we can with I guess it improves accessibility because the track-color can be quite close to the background color and with the stop indicator it's easier to see where the progress bar ends. Still, it's your call, I'm fine either way. |
|
Then I think I would prefer dropping the stop indicator for now, until thus becomes more commonly used in other apps. What do you think, @keunes? |
|
I see the benefit of the stop indicator for accessibility; it makes the ending of an otherwise low-contrast line (the light gray) nicely visible for visually impaired users. However, we don't really need it I think as our total episode time also kinda delineates the end of the line. So I'm fine to remove it (for now). But the new progress indicator looks nice! (Should the one in the player screen be updated accordingly?) |
| android:layout_weight="1" | ||
| android:max="100" | ||
| android:layout_margin="4dp" | ||
| style="?android:attr/progressBarStyleHorizontal" /> |
There was a problem hiding this comment.
Yeah that was needed to tell the native progressbar whether or not it should be linear or circular. But with the new material design there are now to different components.
There was a problem hiding this comment.
Oh sorry, I was actually thinking of progressBarTheme in styles.xml. Didn't read that line properly. How about that theme? Is that still needed?
There was a problem hiding this comment.
Yeah, I'm not quite sure here. I looked into it set's the colors but from what I can tell it's the default colors anyway because the only component it's applied to doesn't seem to have other colors than the other progressbars. And in any way the new indicators use slightly different colors, so I don't think that's needed any longer.
There was a problem hiding this comment.
Okay, could you remove it then, please? :) That should simplify the code. (but please first check if removing breaks something with the dynamic Material You colors)
flofriday
force-pushed
the
new-linear-progress-bars
branch
2 times, most recently
from
c02439d to
212d3f4
Compare
flofriday
force-pushed
the
new-linear-progress-bars
branch
from
212d3f4 to
33d9486
Compare
|
Great, I updated the code and it now looks like:
|
| @@ -47,14 +47,15 @@ | |||
|
|
|||
| </androidx.swiperefreshlayout.widget.SwipeRefreshLayout> | |||
|
|
|||
| <ProgressBar | |||
| <com.google.android.material.progressindicator.LinearProgressIndicator | |||
There was a problem hiding this comment.
Are you sure that this one should be linear?
There was a problem hiding this comment.
No, that seems like an oversight on my end
Description
Updated the progress bars to the new material design progress indicators.
This PR only focuses on the linear progress bars.
Screenshot (before/after):
Checklist
./gradlew checkstyle spotbugsPlayDebug spotbugsDebug :app:lintPlayDebug