Fix typo in Statement-level triggers docs #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g-nie
force-pushed
the
fix-docs-typo
branch
from
fd24273 to
b9b6bb7
Compare
docs/cookbook.md
Outdated
| @@ -379,7 +379,7 @@ class TrackedModel(models.Model): | |||
| With this statement-level trigger, we have the benefit that only one additional query is performed, even on bulk inserts to the tracked model. Here's some example code to illustrate what the results look like. | |||
|
|
|||
| ```python | |||
| TrackedModel.objects.bulk_create([LoggedModel(field='old'), LoggedModel(field='old')]) | |||
| TrackedModel.objects.bulk_create([HistoryModel(field='old1'), HistoryModel(field='old2')]) | |||
There was a problem hiding this comment.
I believe it should be [TrackedModel(field='old1'), TrackedModel(field='old2')]. The HistoryModel is what preserves the historical versions. We bulk create TrackedModel and the HistoryModel objects are created behind the scenes.
Definitely was a typo here at some point, so thanks for correcting it and making the example better!
There was a problem hiding this comment.
Oh right, silly me 😅
Thanks, I just updated it
|
Had one correction, but otherwise I'm good to merge. I will fix it if I don't hear back. Thank you! |
g-nie
force-pushed
the
fix-docs-typo
branch
from
b9b6bb7 to
9026194
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a wrong model name in the code example of the "Statement-level triggers and transition tables" section.
I'm also using different
fieldvalues for extra clarity.