Improve Public Interface Types #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -187,9 +190,9 @@ class Timing(_Primitive): | |||
| class Condition: | |||
| """For specifying free-form SQL in the condition of a trigger.""" | |||
|
|
|||
| sql: str = None | |||
| sql: str | None = None | |||
There was a problem hiding this comment.
I'm assuming you'll need to use Union for 3.8 compat, right?
There was a problem hiding this comment.
Nope, since I added from __future__ import annotations
There was a problem hiding this comment.
You can use it in earlier versions when type annotations are stringified.
There was a problem hiding this comment.
Oh nice, I should convert this elsewhere. I do believe there is a py3.8 bug if you check circle though
File "/code/pgtrigger/runtime.py", line 154, in <module>
def ignore(*uris: str, databases: Union[List[str], None] = None) -> Generator[None]:
TypeError: 'ABCMeta' object is not subscriptable```
There was a problem hiding this comment.
Ah, had to add a future imports for that.
wesleykendall
approved these changes
Sep 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements to the public interface types. The main QoL improvement is probably going to be fixing type-checking when passing in unioned/intersected
pgtrigger.Qinstances.