Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for bytes SQL #171

Merged
merged 8 commits into from
Sep 8, 2024
Merged

Account for bytes SQL #171

merged 8 commits into from
Sep 8, 2024

Conversation

max-muoto
Copy link
Contributor

Fixes #167

@wesleykendall
Copy link
Member

The fix will also need to be applied to _inject_pgtrigger_ignore similar to pghistory's _inject_history_context. I put a test in pghistory to validate that byte strings work too.

Let me know if you're able to add this as well so it's fully fixed. I can do it too

@max-muoto
Copy link
Contributor Author

The fix will also need to be applied to _inject_pgtrigger_ignore similar to pghistory's _inject_history_context. I put a test in pghistory to validate that byte strings work too.

Let me know if you're able to add this as well so it's fully fixed. I can do it too

Handled that, and added a test: e9f0b50

@wesleykendall wesleykendall merged commit 6eaa768 into main Sep 8, 2024
4 checks passed
@wesleykendall wesleykendall deleted the account-for-bytes-sql branch September 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wesleykendall wesleykendall Awaiting requested review from wesleykendall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: startswith first arg must be bytes or a tuple of bytes, not str
2 participants
@max-muoto @wesleykendall