Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do additional error checking for arguments supplied to FSM trigger. #143

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

wesleykendall
Copy link
Member

Type: trivial

@wesleykendall wesleykendall force-pushed the fsm-trigger-error-checking branch from 4dbf6d8 to e203834 Compare November 26, 2023 21:31
@wesleykendall wesleykendall merged commit f8d9fbf into master Nov 26, 2023
2 of 4 checks passed
@wesleykendall wesleykendall deleted the fsm-trigger-error-checking branch November 26, 2023 21:35
Comment on lines +197 to +198
with pytest.raises(ValueError, match="must not have quotes"):
pgtrigger.FSM(field="hello", separator="'", transitions=[("a", "b")])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also check for " (as done for the transition value)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants