Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console update v2 #24

Merged
merged 1 commit into from
Oct 14, 2019
Merged

Console update v2 #24

merged 1 commit into from
Oct 14, 2019

Conversation

yoshikinoko
Copy link
Contributor

@yoshikinoko yoshikinoko commented Sep 25, 2019 •
edited
Loading

This is just a draft proposal for #23. and here's a summary for updates.

  • setup linter. (eslint, pritter) -> excluded form this PR, see setup eslint and prettier #26
  • setup ajv as schema valiadtor of manifest.json
  • updated validation schema for manifest.json ( lib/manifestSchema.js )

Thanks!

@kerrishotts
Copy link
Contributor

@yoshikinoko , can you resolve the conflict with commands/package.js? There was a PR before yours that took care of a typo, so wanted to get that in before merging the rest of this in.

@yoshikinoko
Copy link
Contributor Author

@kerrishotts fixed the conflicts, please check.

@yoshikinoko yoshikinoko self-assigned this Oct 3, 2019
@rodi01
Copy link

rodi01 commented Oct 12, 2019

Will this get merged in before the October 15th deadline?

kerrishotts
kerrishotts approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@kerrishotts kerrishotts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging

@kerrishotts kerrishotts merged commit 448d198 into AdobeXD:master Oct 14, 2019
@yoshikinoko yoshikinoko mentioned this pull request Oct 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerrishotts kerrishotts kerrishotts approved these changes

Assignees

@yoshikinoko yoshikinoko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yoshikinoko @kerrishotts @rodi01