Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): Fix bug in deploy script causing TURBO_TOKEN to not be uploaded as a worker secret #98

Merged
merged 1 commit into from
Sep 23, 2023
Merged

(fix): Fix bug in deploy script causing TURBO_TOKEN to not be uploaded as a worker secret #98

merged 1 commit into from
Sep 23, 2023

Conversation

AdiRishi
Copy link
Owner

@AdiRishi AdiRishi commented Sep 23, 2023 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chore: Updated deployment workflow with secure access to Turbo token. This change enhances the security of our deployment process by ensuring that the Turbo token is securely accessed and available during deployment. This update does not directly impact end-user functionality but contributes to maintaining a robust and secure application infrastructure.

@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2023 •
edited
Loading

Walkthrough

The change introduces a secure way to access the Turbo token during the deployment process. This is achieved by adding an environment variable and a secret TURBO_TOKEN to the deployment step in the workflow file.

Changes

File Summary
.github/workflows/deploy.yml Added TURBO_TOKEN as an environment variable and secret to securely access the Turbo token during deployment.

🐇

In the land of code, where secrets lie,
A token's added, under GitHub's sky.
With Turbo speed, the deploy will run,
Celebrate, dear rabbit, our work is done! 🎉

Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • Mention @coderabbitai in any review comment for bot assistance.
  • Note: Review comments are made on code diffs or files, not on the PR overview.

Pause Incremental Reviews

  • Insert @coderabbitai: ignore in the PR description to halt the bot's ongoing reviews. Remove the line to resume.

coderabbitai[bot]
coderabbitai bot reviewed Sep 23, 2023
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Commits Files that changed from the base of the PR and between 91d7d77 and e3e28bb.
Files selected for processing (1)
  • .github/workflows/deploy.yml (2 hunks)
Files skipped from review due to trivial changes (1)
  • .github/workflows/deploy.yml

@AdiRishi AdiRishi merged commit 8210bb6 into master Sep 23, 2023
4 checks passed
@AdiRishi AdiRishi deleted the arishi-dev branch September 23, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AdiRishi