[cuegui] Fix issue on opening job comments #1532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommentListDialog expects a list of jobs and at some point the input got changed to the first job on the list. Opening the comments dialog on the current version returns: ``` TypeError: 'Job' object is not iterable ```
DiegoTavares
force-pushed
the
fix_job_comments_widget
branch
from
ed0a962 to
c32e75c
Compare
DiegoTavares
requested review from
bcipriano and
ramonfigueiredo
as code owners
ramonfigueiredo
approved these changes
Oct 8, 2024
DiegoTavares
merged commit 6f7702e
into
AcademySoftwareFoundation:master
12 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CommentListDialog expects a list of jobs and at some point the input got changed to the first job on the list.
Opening the comments dialog on the current version returns: